? bug PR-4.4-dev Pending

User tests: Successful: Unsuccessful:

avatar Hackwar
Hackwar
30 Apr 2023

Pull Request for Issue #40503 .

Summary of Changes

This is the PR to fix this in 4.4-dev. When installing Joomla on a different database server than localhost, a check is done to ensure that you are really the person having control over the server. This check writes a file to the filesystem and the content is empty. The code called File::write() with the string-literal, which is not valid, since you can't hand over a string-literal by reference. This PR first creates a variable, which then is handed over as the content for File::write().

Testing Instructions

Install Joomla 4.4-dev on a system and don't use localhost as your database server. Alternatively modify installation/src/Helper/DatabaseHelper.php in checkRemoteDbHost() to execute the check even though you are installing to localhost.

Actual result BEFORE applying this Pull Request

You get a red warning in the browser.

Expected result AFTER applying this Pull Request

Installation passes without error messages.

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar joomla-cms-bot joomla-cms-bot - change - 30 Apr 2023
Category Installation
avatar Hackwar Hackwar - open - 30 Apr 2023
avatar Hackwar Hackwar - change - 30 Apr 2023
Status New Pending
avatar richard67 richard67 - test_item - 1 May 2023 - Tested successfully
avatar richard67
richard67 - comment - 1 May 2023

I have tested this item successfully on 24b3306

Important hint for other testers:

When having done the test without the patch to reproduce the issue, you should either delete the session cookie with your broswer's developer tools or close the browser window to make sure that the browser session is cleared before testing the patch.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40514.

avatar ChristineWk ChristineWk - test_item - 1 May 2023 - Tested successfully
avatar ChristineWk
ChristineWk - comment - 1 May 2023

I have tested this item successfully on 24b3306

With Prebuilt Package


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40514.

avatar richard67 richard67 - change - 1 May 2023
Status Pending Ready to Commit
Labels Added: PR-4.4-dev
avatar richard67
richard67 - comment - 1 May 2023

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40514.

avatar laoneo laoneo - change - 2 May 2023
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2023-05-02 06:50:05
Closed_By laoneo
Labels Added: ? bug
avatar laoneo laoneo - close - 2 May 2023
avatar laoneo laoneo - merge - 2 May 2023
avatar laoneo
laoneo - comment - 2 May 2023

Thanks!

Add a Comment

Login with GitHub to post a comment