? Success

User tests: Successful: Unsuccessful:

avatar nonumber
nonumber
1 Aug 2014

Tracker item: http://joomlacode.org/gf/project/joomla/tracker/?action=TrackerItemEdit&tracker_item_id=34026&start=0

This PR fixes 2 issues in pretty much all search views in the admin side:

  • leading/trailing spaces are not ignored
  • foo bar will not match foo xxx bar

So to test:

  • Search for the beginning part of something in the list and add a space before it.
  • Search for the ending part of something in the list and add a space after it.
  • Search - for example - for something that has three parts/words. But only enter the first and last part/word in the search field (separated by a space).

Unpatched the above should not return the item you are looking for. With this fix it should.

Check the Files changes to see which views are affected (and should be tested).

avatar nonumber nonumber - open - 1 Aug 2014
avatar jissues-bot jissues-bot - change - 1 Aug 2014
Closed_Date 0000-00-00 00:00:00 2014-08-01 10:38:33
Labels Added: ? ?
avatar jissues-bot jissues-bot - close - 1 Aug 2014
avatar jissues-bot jissues-bot - close - 1 Aug 2014
avatar nonumber nonumber - change - 1 Aug 2014
Status New Closed
avatar nonumber nonumber - close - 1 Aug 2014
avatar nonumber nonumber - change - 1 Aug 2014
The description was changed
Description <p>This PR fixes 2 issues in pretty much all search views in the admin side:</p> <ul class="task-list"> <li>leading/trailing spaces are not ignored</li> <li> <code>foo bar</code> will not match <code>foo xxx bar</code> </li> </ul><p>Affected list views in this PR:</p> <ul class="task-list"> <li>com_modules</li> <li>com_plugins</li> </ul> <p>This PR fixes 2 issues in pretty much all search views in the admin side:</p> <ul class="task-list"> <li>leading/trailing spaces are not ignored</li> <li> <code>foo bar</code> will not match <code>foo xxx bar</code> </li> </ul><p>Check the Files changes to see which views are affected (and should be tested).</p>
Status Closed New
avatar nonumber nonumber - reopen - 1 Aug 2014
avatar brianteeman brianteeman - change - 1 Aug 2014
Labels Added: ?
Removed: ?
avatar brianteeman brianteeman - change - 1 Aug 2014
Title
Improved search functionality in list views
[#34026] Improved search functionality in list views
avatar brianteeman brianteeman - change - 1 Aug 2014
Title
Improved search functionality in list views
[#34026] Improved search functionality in list views
avatar n9iels
n9iels - comment - 3 Aug 2014

can you explain how i have to test this PR?

avatar nonumber
nonumber - comment - 3 Aug 2014

Added testing instructions to description.

avatar Bakual
Bakual - comment - 4 Aug 2014

For testers: This refers to the search field in the administrator list views.

My testing result: The patch works fine and makes sense. I think the same should be done in frontend as well, but it can be done in a separate PR if there is interest.

avatar n9iels
n9iels - comment - 4 Aug 2014

@test: Patch works fine for me, thx for this

avatar Bakual Bakual - change - 4 Aug 2014
Status New Ready to Commit
avatar Bakual Bakual - change - 4 Aug 2014
Labels Added: ?
avatar Bakual Bakual - change - 6 Aug 2014
Status Ready to Commit Closed
Closed_Date 2014-08-01 10:38:33 2014-08-06 19:09:26
avatar Bakual Bakual - close - 6 Aug 2014

Add a Comment

Login with GitHub to post a comment