Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#40508] - [4] GET request scheduled task plugin - Authorization 401

? ? bug PR-4.3-dev Pending

User tests: Successful: Unsuccessful:

avatar alikon
alikon
30 Apr 2023

Pull Request for Issue # .

Summary of Changes

fix header for Authorization

Testing Instructions

  • create a GET request scheduled task
  • fill a request URL
  • enable Authorization
  • fill the key
  • run the task

Actual result BEFORE applying this Pull Request

401

Expected result AFTER applying this Pull Request

200

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar joomla-cms-bot joomla-cms-bot - change - 30 Apr 2023
Category ⇒ Front End Plugins
avatar alikon alikon - open - 30 Apr 2023
avatar alikon alikon - change - 30 Apr 2023
Status New ⇒ Pending
avatar richard67
richard67 - comment - 30 Apr 2023

@alikon I think you have to adapt the expected result of the unit tests (file tests/Unit/Plugin/Task/Requests/Extension/RequestsPluginTest.php line 242) to your change, see https://ci.joomla.org/joomla/joomla-cms/65072/1/11 .

avatar joomla-cms-bot joomla-cms-bot - change - 30 Apr 2023
Category Front End Plugins ⇒ Front End Plugins Unit Tests
avatar alikon alikon - change - 30 Apr 2023
Labels Added: PR-4.3-dev
avatar alikon alikon - change - 30 Apr 2023
Labels Added: ?
avatar richard67
richard67 - comment - 30 Apr 2023

Unit tests are passing. Failing system tests in drone are not related to this PR. I will restart later to see if they succeed.

avatar richard67
richard67 - comment - 30 Apr 2023

@alikon In the testing instructions you wrote:

create a GET request scheduled task plugin

But I think it just needs to create a task, not write an own plugin, is that right?

avatar alikon
alikon - comment - 30 Apr 2023

yes

avatar alikon alikon - change - 30 Apr 2023
The description was changed
avatar alikon alikon - edited - 30 Apr 2023
avatar richard67 richard67 - test_item - 30 Apr 2023 - Tested successfully
avatar richard67
richard67 - comment - 30 Apr 2023

I have tested this item ✅ successfully on 759f443

I have used a hack for testing with Basic authentication, which is not available in the dropdown for the authentication type. So I have set in database in the task's params the "authType" to "Basic" and the "authKey" to the bease64 encoded combination of user name and password separated by a colon. This worked, i.e. without the PR applied I got a 401 and with the PR applied a 200.

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40508.

avatar Quy Quy - test_item - 8 Aug 2023 - Tested successfully
avatar Quy
Quy - comment - 8 Aug 2023

I have tested this item ✅ successfully on 759f443

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40508.

avatar Quy Quy - change - 8 Aug 2023
Status Pending ⇒ Ready to Commit
avatar Quy
Quy - comment - 8 Aug 2023

RTC

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40508.

avatar Quy Quy - change - 8 Aug 2023
Labels Added: ? bug
avatar obuisard obuisard - close - 9 Aug 2023
avatar obuisard obuisard - merge - 9 Aug 2023
avatar obuisard obuisard - change - 9 Aug 2023
Status Ready to Commit ⇒ Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 ⇒ 2023-08-09 01:12:03
Closed_By ⇒ obuisard
avatar obuisard
obuisard - comment - 9 Aug 2023

Thank you Nicola @alikon for the PR!

Add a Comment

Login with GitHub to post a comment