?
Referenced as Related to: # 4841

User tests: Successful: Unsuccessful:

avatar rvbgnu
rvbgnu
1 Aug 2014

http://joomlacode.org/gf/project/joomla/tracker/?action=TrackerItemEdit&tracker_item_id=32007&start=0

[#32007] Adapting George PR #3239 against staging to work against 2.5.x branch

Votes

# of Users Experiencing Issue
1/1
Average Importance Score
3.00

avatar rvbgnu rvbgnu - open - 1 Aug 2014
avatar jissues-bot jissues-bot - change - 1 Aug 2014
Labels Added: ? ?
avatar brianteeman brianteeman - change - 1 Aug 2014
Labels Added: ?
Removed: ?
avatar infograf768
infograf768 - comment - 10 Aug 2014

Why create a second variable for the same value?

$uParams    = JComponentHelper::getParams('com_users');

+       // Check for admin activation. Don't allow non-super-admin to delete a super admin
+       $userParams = JComponentHelper::getParams('com_users');
+ 
+       if ($userParams->get('useractivation') != 2 && $user->get('id'))

we already have $uparams...

avatar rvbgnu
rvbgnu - comment - 12 Aug 2014

Confusion between model and controller... Thanks Jean-Marie for spotting it ;-)

avatar rvbgnu
rvbgnu - comment - 12 Aug 2014

PR updated!
Please test

avatar brianteeman brianteeman - change - 21 Aug 2014
Status New Pending
avatar nicksavov nicksavov - change - 21 Aug 2014
Labels Removed: ?
avatar infograf768
infograf768 - comment - 29 Sep 2014

Do NOT merge this.
See issue here:
#4376

avatar rvbgnu
rvbgnu - comment - 17 Oct 2014

@test
I can reproduce the issue on 2.5.28-dev, it is still there. But it has been fixed in 3.3.x but with different PRs, revert from regression. Please help me to find what code should be back ported from 3.3.x, if possible, to fix this in 2.5.x!

avatar rvbgnu
rvbgnu - comment - 17 Oct 2014

@infograf768 thanks for pointing the issue for NOT merging this (I am STILL learning joomla core code while contributing) but how to fix this now?

avatar brianteeman brianteeman - change - 17 Oct 2014
Category Components
avatar brianteeman brianteeman - change - 17 Oct 2014
Title
[#32007] 2.5.x Fix admin activation from email
2.5.x Fix admin activation from email
avatar infograf768 infograf768 - close - 18 Oct 2014
avatar infograf768 infograf768 - change - 18 Oct 2014
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2014-10-18 05:45:53
avatar infograf768 infograf768 - change - 18 Oct 2014
Title
2.5.x Fix admin activation from email
[#32007] 2.5.x Fix admin activation from email
avatar rvbgnu
rvbgnu - comment - 18 Oct 2014

Well, persevering, after having read a lot on docs.joomla.org... The issue is still there, was initially reported on JoomlaCode. This was ONLY a PR to fix it, but PR code is no good. So I've open an new issue #4841 without PR, copying details from issue report. Thanks.

Add a Comment

Login with GitHub to post a comment