No Code Attached Yet bug
avatar Attila-SWE
Attila-SWE
24 Apr 2023

Steps to reproduce the issue

  1. Any backend admin component with several thousand entries (com_users has same issue)
  2. Press clear in filter row next to search
  3. List limit is also cleared
  4. Joomla tries to show all entries
  5. Memory exhaustion if too many entries

Expected result

Keeping selection limit and removing other filters

Actual result

Out of memory

avatar Attila-SWE Attila-SWE - open - 24 Apr 2023
avatar joomla-cms-bot joomla-cms-bot - change - 24 Apr 2023
Labels Added: No Code Attached Yet
avatar joomla-cms-bot joomla-cms-bot - labeled - 24 Apr 2023
avatar richard67 richard67 - change - 24 Apr 2023
Labels Added: bug
avatar richard67 richard67 - labeled - 24 Apr 2023
avatar conseilgouz
conseilgouz - comment - 25 Apr 2023

@Attila-SWE : is debug enabled ?

avatar Attila-SWE
Attila-SWE - comment - 25 Apr 2023

@Attila-SWE : is debug enabled ?

Yes. But even when disabling all debug functions the limit dropdown is cleared when pressing "clear"-button:

image

which results in all entries being fetched and displayed. We have thousands of members so pressing clear leads to same results even when debug is disabled (just tested it).

Since this affects all filters using searchtools including all native components (in backend of what I have seen so far) I would consider this a critical issue.

avatar Fedik
Fedik - comment - 25 Apr 2023

I can confirm, it affects all filters in backend.
Probably result of #39772

avatar chmst
chmst - comment - 25 Apr 2023

@Attila-SWE is this a new bug or was it also in Joomla 4.2?

avatar Fedik
Fedik - comment - 25 Apr 2023

It is new, for 4.3.
In 4.2 works good

avatar Attila-SWE
Attila-SWE - comment - 25 Apr 2023

@Attila-SWE is this a new bug or was it also in Joomla 4.2?

Did not notice in 4.2.x

avatar richard67 richard67 - change - 25 Apr 2023
Labels Added: Release Blocker
avatar richard67 richard67 - labeled - 25 Apr 2023
avatar fontanil
fontanil - comment - 25 Apr 2023

Hi,

I didn't get an error (small count of data on my test sites) but the "clear" button is always enabled (disabled if no filter on 4.2.9) and clicking sets the number of items to 25 instead of the default list limit or a previous change in that list.

avatar Attila-SWE
Attila-SWE - comment - 25 Apr 2023

Hi,

I didn't get an error (small count of data on my test sites) but the "clear" button is always enabled (disabled if no filter on 4.2.9) and clicking sets the number of items to 25 instead of the default list limit or a previous change in that list.

Yes. Clear-button is enabled constantly.

If you watch closely to what happens the clear button changes list limit to empty, resends the form, loads all data no matter what number is shown as limit after page reload and then the list limit field is set to some default value (but not respected as all entries already have been loaded).

avatar dgrammatiko
dgrammatiko - comment - 25 Apr 2023

Check #40398

avatar richard67
richard67 - comment - 25 Apr 2023

From what I can see, PR #40398 also fixes the unwanted reset of the ordering and the list limit fields and so could indeed fix also this issue here . But I don't have the huge amount of data to check the out of memory aspect.

What I can see is that for a short moment, the 2 fields are still cleared when that PR is applied, but after that they have their previous value, i.e. are not reset.

avatar richard67
richard67 - comment - 25 Apr 2023

Hi,

I didn't get an error (small count of data on my test sites) but the "clear" button is always enabled (disabled if no filter on 4.2.9) and clicking sets the number of items to 25 instead of the default list limit or a previous change in that list.

This has been clearly fixed with #40398 , which will hopefully be included in the upcoming 4.3.1 bugfix release.

avatar Attila-SWE
Attila-SWE - comment - 25 Apr 2023

From what I can see, PR #40398 also fixes the unwanted reset of the ordering and the list limit fields and so could indeed fix also this issue here . But I don't have the huge amount of data to check the out of memory aspect.

What I can see is that for a short moment, the 2 fields are still cleared when that PR is applied, but after that they have their previous value, i.e. are not reset.

You do not need huge data. Go to com_content or com_menu and test to clear search. After page reload you can scroll and see if you have more than the number of entries showing that the list limit would suggest. For example in com_content it says 25 but shows all 800 articles for me.

avatar richard67
richard67 - comment - 25 Apr 2023

@Attila-SWE Then test the pull request #40398 . You should do that on a testing environment, a copy of your real site in a subfolder or a subdomain or on a local environment. You can update that testing site to the pull request by using either the custom update URL or the update zip package "Joomla_4.3.0-rc4-dev+pr.40398-Development-Update_Package.zip" linked on this page: https://ci.joomla.org/artifacts/joomla/joomla-cms/4.3-dev/40398/downloads/64739/ .

The custom update URL can be used in the options of the Joomla Update Component when using "Custom URL" as update source, and then you can do a live update with that. Or you download the "Joomla_4.3.0-rc4-dev+pr.40398-Development-Update_Package.zip" and used that for the Upload & Update method of the Joomla Update Component.

If that PR solves your problem, please report back here. Thanks in advance.

avatar richard67
richard67 - comment - 25 Apr 2023

@Attila-SWE P.S.: For me that pull request solves your issue. After page reload, the list still shows as many items as set by the list limit, and the list limit has not changed.

avatar richard67
richard67 - comment - 25 Apr 2023

@dgrammatiko Hmm, your PR #40398 solves this issue for me for the patchtester component's list view, but not for the content/categories list.

avatar brianteeman
brianteeman - comment - 25 Apr 2023

#40398 is not a complete fix

avatar richard67
richard67 - comment - 25 Apr 2023

#40398 is not a complete fix

Not for this issue here, but for the other issue which it claims to fix, it is complete.

avatar Attila-SWE
Attila-SWE - comment - 25 Apr 2023

Issue #40475 not solved with updating media/system/js/searchtools.js from https://ci.joomla.org/artifacts/joomla/joomla-cms/4.3-dev/40398/downloads/64739/ but solves issue with active clear button if no filter.

avatar richard67
richard67 - comment - 25 Apr 2023

@Attila-SWE You are right. The PR will be updated soon to fix also this issue here. We will let you know when that is ready and give you the new link to the downloads. Thanks for reporting back.

avatar richard67
richard67 - comment - 25 Apr 2023

@Attila-SWE The pull request is ready now. You can find the new donloads and update IRL here: https://ci.joomla.org/artifacts/joomla/joomla-cms/4.3-dev/40398/downloads/64986/ . Thanks in advance for testing.

avatar richard67
richard67 - comment - 25 Apr 2023

Closing as having a pull request. Please test #40398 . Thanks in advance.

avatar richard67 richard67 - close - 25 Apr 2023
avatar richard67 richard67 - change - 25 Apr 2023
Status New Closed
Closed_Date 0000-00-00 00:00:00 2023-04-25 11:38:48
Closed_By richard67
avatar richard67 richard67 - change - 25 Apr 2023
Labels Removed: Release Blocker
avatar richard67 richard67 - unlabeled - 25 Apr 2023

Add a Comment

Login with GitHub to post a comment