[#40473] - [4.3] Fix sort by menu in com_associations
- Closed
- 8 Sep 2023
- Medium
- Build: 4.3-dev
- # 40473
- Diff
- brianteeman:patch-13
User tests: Successful: Unsuccessful:
Summary of Changes
Completes the functionality of the sort by menuitem
Testing Instructions
On a multilingual site with sample data go to the associations component
Select menu items and a language
Observe that there is no Sort by Menu in the dropdown
but you can sort by clicking on the Menu column header
Actual result BEFORE applying this Pull Request
You can only sort by clicking on the Menu column header
Clicking on the column header does not show the correct information in the dropdown
Expected result AFTER applying this Pull Request
You can sort by clicking on the Menu column header
Or by clicking on the option in the dropdown
AND the collapsed option will show the correct value
AND that these menu sort options are only available for a menu items item type
Additional comment
The extra sort option is appended to the end of the options and not in column order. This bug is the same as observed with the workflows component
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
joomla-cms-bot
- | Category | ⇒ | Administration com_associations |
| Status | New | ⇒ | Pending |
thanks for testing - I will take a look when I get the chance
Brian @brianteeman, would you like to take another look, this enhancement would be great in 5.0.
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2023-09-08 11:52:54 |
| Closed_By | ⇒ | brianteeman | |
| Labels |
Added:
bug
PR-4.3-dev
|
||
I have tested this item? unsuccessfully on 3c4ba98
The PR works as described.
But when after the test still in the list view of the Associations component I change the Item Type from "Menu Items" to something else, e.g. "Articles", I get an error 500 "Unknown column 'menutype_title' in 'order clause'", and to get rid of it I have to clear session data where the ordering from the previous test has been saved.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40473.