Language Change PR-4.4-dev Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
24 Apr 2023

When the debug plugin was refactored for j4 using phpdugbar a large number of strings were remaining that are simply not used. Basically only the strings in the plugin settings are used. The plugin itself is only in english and does not use translatabvle strings.

This PR deprecates all 45 unused strings so that they can be removed in 5.0 and TT have less work to do

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar joomla-cms-bot joomla-cms-bot - change - 24 Apr 2023
Category Administration Language & Strings
avatar brianteeman brianteeman - open - 24 Apr 2023
avatar brianteeman brianteeman - change - 24 Apr 2023
Status New Pending
avatar laoneo
laoneo - comment - 24 Apr 2023

Deprecations should always go into the next minor release. Can you rebase the pr to 4.4?

avatar brianteeman brianteeman - change - 24 Apr 2023
Title
[4.3] Deprecate debug plugin strings
[4.4] Deprecate debug plugin strings
avatar brianteeman brianteeman - edited - 24 Apr 2023
avatar brianteeman
brianteeman - comment - 24 Apr 2023

rebased

avatar brianteeman brianteeman - change - 24 Apr 2023
Labels Added: Language Change PR-4.3-dev
avatar brianteeman brianteeman - change - 25 Apr 2023
Labels Added: PR-4.4-dev
Removed: PR-4.3-dev
avatar laoneo laoneo - change - 2 May 2023
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2023-05-02 16:43:49
Closed_By laoneo
avatar laoneo laoneo - close - 2 May 2023
avatar laoneo laoneo - merge - 2 May 2023
avatar laoneo
laoneo - comment - 2 May 2023

Thanks!

avatar brianteeman
brianteeman - comment - 2 May 2023

thanks

Add a Comment

Login with GitHub to post a comment