[#40465] - Extension Names
- Closed
- 24 Apr 2023
- Medium
- Build: 4.3-dev
- # 40465
<name>plg_workflow_publishing</name>
<author>Joomla! Project</author>
<creationDate>2020-03</creationDate>
<copyright>(C) 2020 Open Source Matters, Inc.</copyright>
<license>GNU General Public License version 2 or later; see LICENSE.txt</license>
<authorEmail>admin@joomla.org</authorEmail>
<authorUrl>www.joomla.org</authorUrl>
<version>4.0.0</version>
<description>PLG_WORKFLOW_PUBLISHING_XML_DESCRIPTION</description>
Is there a reason that the value for name is lowercase?
It is a language string and all other language strings are uppercase.
If there is no reason for it to be lowercase would it not be better to change them all to uppercase for consistency?
joomla-cms-bot
- | Labels |
Added:
No Code Attached Yet
|
||
It's the same, the
Text::_()will always make the passed string uppercase:
For me it should be in uppercase for codestyle
I was just pointing out that any case (lower/upper/mixed) will be treated the same. For CS consistency obviously is better to have uniformity. Taking it one step further you could deprecate the line I mentioned above and make it a strict rule that for v6 (or later) the string passed should be uppercase... (not really a perf bottleneck, there are other languages optimisations that could have way bigger impact)
@laoneo @HLeithner thoughts? 4.4 or 5?
I expect all extensions are lowercase and I think it's not only the title it's also used for the folder name? But not sure about this. For me it's ok lowercase but don't care too much.
the folder name isnt a translatable string
I mean that the name-tag is the folder name but not sure only came to my head
The name is like that inserted in the database and for example I do some queries for names in my extension during upgrade or installation. I' do imagine other extension devs are doing the same. So I think this would be a rather hard BC break. I would leave it as it is as the name is not only used for language strings.
OK THANKS
| Status | New | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2023-04-24 13:23:04 |
| Closed_By | ⇒ | brianteeman |
It's the same, the
Text::_()will always make the passed string uppercase:joomla-cms/libraries/src/Language/Language.php
Line 320 in c93bdfd