[#40455] - Tags router: unset Itemid for not matching menu, in the end of build
- Fixed in Code Base
- 24 Apr 2023
- Medium
- Build: 4.3-dev
- # 40455
- Diff
- Fedik:fix-40442-2
User tests: Successful: Unsuccessful:
Pull Request for Issue #40442 redo of #40448 .
Summary of Changes
Other way around,
Unset Itemid for not matching menu, in the end of Router::build.
Testing Instructions
Please follow #40442
Also open Tags list URL /component/tags/tags and check paginations links (Tag menu should be unpublished or not exists)
Actual result BEFORE applying this Pull Request
the url contain Itemid
Expected result AFTER applying this Pull Request
the url does not contain Itemid
Link to documentations
Please select:
- Documentation link for docs.joomla.org:
- No documentation changes for docs.joomla.org needed
- Pull Request link for manual.joomla.org:
- No documentation changes for manual.joomla.org needed
joomla-cms-bot
- | Category | ⇒ | com_tags Front End |
| Status | New | ⇒ | Pending |
@ch2856 Could you go to the issue tracker here https://issues.joomla.org/tracker/joomla-cms/40455 , then use the blue "Test this" button at the top left corner, and then select your test result (success as far as I understood) and finally submit? Thanks in advance.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40455.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40455.
| Status | Pending | ⇒ | Ready to Commit |
| Labels |
Added:
bug
PR-4.3-dev
?
|
||
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40455.
I've remove the release blocker label because as far as I can see the pagination links had the Itemid query parameter also in 4.2.9. But there the pagination links were broken. On a clean, current 4.3-dev branch they work without this PR but still have the Itemid, and with this PR they don't have the Itemid and the links still work.
As far as I remember, before J4 we had no itemid using pagination. Since J4 the pagination for tags was broken so the solution here is the right one.
As far as I remember, before J4 we had no itemid using pagination. Since J4 the pagination for tags was broken so the solution here is the right one.
@ch2856 As you can see I have successfully tested this PR, so I have no doubt that it is right and good. What I meant is that it's not a release blocker due to our definitions.
sdwjoomla
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2023-04-24 23:47:27 |
| Closed_By | ⇒ | sdwjoomla | |
| Labels |
Added:
?
|
||
Tested, issue resolved, no itemid on pagination as well.
I didn't used the file it self, just changed line 185 since lines 155-157 brakes the site.
155-157 original:
$menuItem = $this->menu->getItem($query['Itemid']); if ($menuItem->query['option'] == 'com_tags') {155-157 in the file here:
$menuItem = !empty($query['Itemid']) ? $this->menu->getItem($query['Itemid']) : false; if ($menuItem && $menuItem->query['option'] == 'com_tags') {