Joomla! Issue Tracker | Joomla! CMS #40442 - [4.3] Tags router changes adds itemid

No Code Attached Yet bug

Closed
21 Apr 2023
Medium
Build: 4.3-dev
# 40442

brianteeman
21 Apr 2023

B/C Break!!

Steps to reproduce the issue

Joomla 4.3 with sample data installed and SEF urs enabled

On the home pge click on any of the tags

Expected result

urls in the format domain/component/tags/tag/tagname

Actual result

urls in the format domain/component/tags/tag/tagname?itemid=xxx

In Joomla 4.2

urls in the format domain/component/tags/tag/tagname

Additional comments

This is probably the result of the changes in #39114
This is possibly related to #40423

I have confirmed this on both clean installs and live sites. and there have been multiple reports elsewhere

brianteeman - open - 21 Apr 2023

joomla-cms-bot - change - 21 Apr 2023

Labels

Added: No Code Attached Yet

joomla-cms-bot - labeled - 21 Apr 2023

brianteeman - change - 21 Apr 2023

The description was changed

brianteeman - edited - 21 Apr 2023

richard67 - change - 21 Apr 2023

Labels

Added: bug

richard67 - labeled - 21 Apr 2023

richard67 - change - 21 Apr 2023

Labels

Added: Release Blocker

richard67 - labeled - 21 Apr 2023

Fedik - comment - 21 Apr 2023

Please try to coment out this code, and check if it helps?

joomla-cms/components/com_tags/src/Service/Router.php

Lines 130 to 137 in 853d324

    
           // If not found, return language specific home link 
        
           if (!isset($query['Itemid'])) { 
        
               $default = $this->menu->getDefault($language); 
        
               if (!empty($default->id)) { 
        
                   $query['Itemid'] = $default->id; 
        
               } 
        
           }

brianteeman - comment - 21 Apr 2023

@Fedik that does revert the urls to the ones that I expected and had previously

HOWEVER I am not a heavy user of tags so I might be missing something

Fedik - comment - 21 Apr 2023

I am not a heavy user of tags so I might be missing something

I also, but the code looks suspicious, it should not set any Itemid, when menu not found.
~~I will make a PR, so other also can test~~

Hm, no, the Itemid used in Router::build(), need something else.

Fedik - comment - 21 Apr 2023

Okay, I made PR, but not sure if it correct,
Please test #40448

richard67 - change - 21 Apr 2023

Status	New	⇒	Closed
Closed_Date	0000-00-00 00:00:00	⇒	2023-04-21 16:06:33
Closed_By		⇒	richard67

richard67 - close - 21 Apr 2023

richard67 - comment - 21 Apr 2023

Closing as having a pull request. Please test #40448 . Thanks in advance.

richard67 - change - 21 Apr 2023

Labels

Removed: Release Blocker

richard67 - unlabeled - 21 Apr 2023

Add a Comment

Older
Newer

Joomla! Issue Tracker - CMS

[#40442] - [4.3] Tags router changes adds itemid

Steps to reproduce the issue

Expected result

Actual result

In Joomla 4.2

Additional comments

Add a Comment

	// If not found, return language specific home link
	if (!isset($query['Itemid'])) {
	$default = $this->menu->getDefault($language);

	if (!empty($default->id)) {
	$query['Itemid'] = $default->id;
	}
	}