? Release Blocker bug PR-4.3-dev Pending

User tests: Successful: Unsuccessful:

avatar joomdonation
joomdonation
20 Apr 2023

Pull Request for Issue #40411

Summary of Changes

This small PR deletes administrator/cache/autoload_psr4.php to prevent fatal error when Joomla is updated using CLI. See #40411 to understand more about the issue.

Please note that this can only fix the issue when users update from next Joomla release 4.3.1 to future Joomla releases. If users update from 4.3.0 or earlier to future Joomla version using CLI, the issue will still happen.

Testing Instructions

  1. Use Joomla 4.3
  2. Modify libraries/src/Version.php, change MINOR_VERSION to 2 and PATCH_VERSION to 9 to fake the current installed Joomla version to 4.2.9
  3. Execute cli/joomla.php core:update

Actual result BEFORE applying this Pull Request

The file administrator/cache/autoload_psr4.php is not deleted, thus causes fatal error when there is changes in new Joomla version requires re-generate namespace map, for example, there new plugin added or plugin converted to new structure...

Expected result AFTER applying this Pull Request

The file administrator/cache/autoload_psr4.php is deleted . It will be re-generated on next page load, thus no fatal error anymore

Link to documentations

Please select:

  • No documentation changes for docs.joomla.org needed
  • No documentation changes for manual.joomla.org needed
avatar joomla-cms-bot joomla-cms-bot - change - 20 Apr 2023
Category Libraries
avatar joomdonation joomdonation - open - 20 Apr 2023
avatar joomdonation joomdonation - change - 20 Apr 2023
Status New Pending
avatar Fedik Fedik - test_item - 20 Apr 2023 - Tested successfully
avatar Fedik
Fedik - comment - 20 Apr 2023

I have tested this item successfully on c287579


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40437.

avatar alikon
alikon - comment - 20 Apr 2023

Expected result AFTER applying this Pull Request
The file administrator/cache/autoload_psr4.php is not deleted . It will be re-generated

it means is deleted and It will be re-generated, right ?

avatar Fedik
Fedik - comment - 20 Apr 2023

it means is deleted and It will be re-generated, right ?

yeap ?

Use Joomla 4.3

Also can use older 4.2 version. And copy changes from the PR.

avatar richard67
richard67 - comment - 20 Apr 2023

it means is deleted and It will be re-generated, right ?

yeap ?

@Fedik What @alikon means is that in the testing instructions that sentence is wrong in the expected result section, maybe because of having been copied from the actual result section. @joomdonation Could you fix that? Thanks in advance.

avatar Fedik
Fedik - comment - 20 Apr 2023

means is that in the testing instructions that sentence is wrong in the expected result section

yes, I understood that, also seen :)

avatar alikon
alikon - comment - 20 Apr 2023

sorry for the noise folks, wanted to be sure i've done my test correctly, as i've understood reading the code

avatar alikon alikon - test_item - 20 Apr 2023 - Tested successfully
avatar alikon
alikon - comment - 20 Apr 2023

I have tested this item successfully on c287579


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40437.

avatar alikon alikon - change - 20 Apr 2023
Status Pending Ready to Commit
avatar alikon
alikon - comment - 20 Apr 2023

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40437.

avatar joomdonation joomdonation - change - 21 Apr 2023
The description was changed
avatar joomdonation joomdonation - edited - 21 Apr 2023
avatar obuisard obuisard - close - 21 Apr 2023
avatar obuisard obuisard - merge - 21 Apr 2023
avatar obuisard obuisard - change - 21 Apr 2023
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2023-04-21 18:33:06
Closed_By obuisard
Labels Added: ? Release Blocker bug PR-4.3-dev
avatar obuisard
obuisard - comment - 21 Apr 2023

Thank you Tuan @joomdonation for the PR

Add a Comment

Login with GitHub to post a comment