Feature Composer Dependency Changed PR-5.0-dev Removal Pending

User tests: Successful: Unsuccessful:

avatar Hackwar
Hackwar
20 Apr 2023

Summary of Changes

This PR adds the Joomla framework language package as a dependency. This is a preparation for using the Filter package of the framework instead of the CMS, which again is a preparation to using the Input package of the framework instead of the CMS one. Overall, we want to reduce duplicate code. I see the irony, that this introduces a big block of duplicated code for now.

Yes, the classes in the CMS are currently sometimes further ahead than the framework ones, containing additional features, however the framework classes generally have higher quality code, better code coverage and have been properly capsulated. That is the reason why we should switch over to those framework packages.

While this PR allows us to deprecate the Filter CMS classes and Input CMS classes, and switch core code over to the framework classes, we still will have to synchronize the language framework package and the CMS language classes.

This also deprecates the methods in the Language class which are related to com_search.

Testing Instructions

Actual result BEFORE applying this Pull Request

Expected result AFTER applying this Pull Request

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org: Commit

  • No documentation changes for manual.joomla.org needed

avatar joomla-cms-bot joomla-cms-bot - change - 20 Apr 2023
Category External Library Composer Change Libraries
avatar Hackwar Hackwar - open - 20 Apr 2023
avatar Hackwar Hackwar - change - 20 Apr 2023
Status New Pending
avatar Hackwar Hackwar - change - 20 Apr 2023
Labels Added: Composer Dependency Changed PR-5.0-dev
avatar Hackwar Hackwar - change - 20 Apr 2023
The description was changed
avatar Hackwar Hackwar - edited - 20 Apr 2023
avatar HLeithner
HLeithner - comment - 3 Jun 2023

I would like to merge it but the deprecation message is not possible (deprecate in 5 remove in 6, if it should be removed in 6 you have to deprecate it in 4.4) and I miss the manual.joomla.org pr

avatar Hackwar Hackwar - change - 5 Jun 2023
Labels Added: Feature Removal
avatar Hackwar
Hackwar - comment - 5 Jun 2023

The deprecations will be handled in #40727.

avatar HLeithner HLeithner - close - 8 Jun 2023
avatar HLeithner HLeithner - merge - 8 Jun 2023
avatar HLeithner HLeithner - change - 8 Jun 2023
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2023-06-08 08:25:11
Closed_By HLeithner
avatar HLeithner
HLeithner - comment - 8 Jun 2023

Thanks

Documentation: joomla/Manual@dc9587a

avatar HLeithner HLeithner - change - 8 Jun 2023
The description was changed
avatar HLeithner HLeithner - edited - 8 Jun 2023

Add a Comment

Login with GitHub to post a comment