PR-4.4-dev Pending

User tests: Successful: Unsuccessful:

avatar Hackwar
Hackwar
18 Apr 2023

Followup Pull Request for pr #40239.

Summary of Changes

Fixes the error message undefined method Folder::exist, which comes from #40239.

image

Testing Instructions

Edit a module in the back end.

Actual result BEFORE applying this Pull Request

Error message.

Expected result AFTER applying this Pull Request

Module can be edited.

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar joomla-cms-bot joomla-cms-bot - change - 18 Apr 2023
Category Libraries
avatar Hackwar Hackwar - open - 18 Apr 2023
avatar Hackwar Hackwar - change - 18 Apr 2023
Status New Pending
avatar laoneo laoneo - change - 18 Apr 2023
The description was changed
avatar laoneo laoneo - edited - 18 Apr 2023
avatar brianteeman
brianteeman - comment - 18 Apr 2023

This fixes the error in the modules but there are lots of other changes in #40239 that need real testing and not just a sinmple code review by one person - there is a reason that we have the testing procedures that we have. And it always breaks when they are not followed

avatar laoneo laoneo - change - 18 Apr 2023
Labels Added: PR-4.4-dev
avatar drmenzelit drmenzelit - test_item - 18 Apr 2023 - Tested successfully
avatar drmenzelit
drmenzelit - comment - 18 Apr 2023

I have tested this item successfully on 67676e5

With this patch is possible to edit and add modules again


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40403.

avatar laoneo
laoneo - comment - 18 Apr 2023

Thank you Hannes. Unfortunately we have here the same issue as in #40131, which was moved to 5.0. I'm closing this one in favor of #40406 which reverts basically the change. As a new Exception is thrown here in a libraries file which is a BC break and should be done in 5.0.

avatar laoneo laoneo - change - 18 Apr 2023
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2023-04-18 11:27:37
Closed_By laoneo
avatar laoneo laoneo - close - 18 Apr 2023

Add a Comment

Login with GitHub to post a comment