No Code Attached Yet bug
avatar Scrabble96
Scrabble96
14 Apr 2023

Steps to reproduce the issue

Make changes to an updated override and then click the X next to the file name in the Updated Files tab

Expected result

File marked as updated and X changed to tick

Actual result

Orange message saying "No file selected"

image

I have tried with the check box to the left of the X ticked and without. With the same result.
I logged out and back in again. Same result.
I cleared the cache. Same result.

System information (as much as possible)

PHP 8.0.28 on Litespeed server

Additional comments

avatar Scrabble96 Scrabble96 - open - 14 Apr 2023
avatar joomla-cms-bot joomla-cms-bot - change - 14 Apr 2023
Labels Added: No Code Attached Yet
avatar joomla-cms-bot joomla-cms-bot - labeled - 14 Apr 2023
avatar richard67 richard67 - change - 14 Apr 2023
Labels Added: bug
avatar richard67 richard67 - labeled - 14 Apr 2023
avatar richard67
richard67 - comment - 16 Apr 2023

I can confirm that changing the checked status by clicking on the "Checked" icon does not work. I have checked on a clean, current 4.3-dev branch with a new installation.

Maybe there is some relation to PR #39380 ?

For creating changed updated files I have proceeded as described in that PR. The SQL statements I have modified so the extension ID and so on are not hard-coded.

So I have created in the template manager in backend for the Cassiopeia template overrides of the default views of com_content/article and com_newsfeed/newsfeed.

Then I have run the following SQL statements to create the two changed overrides, replacing the #__ by my actual table prefix:

INSERT INTO `#__template_overrides` (`id`, `template`, `hash_id`, `extension_id`, `state`, `action`, `client_id`, `created_date`, `modified_date`)
SELECT 1, `name`, 'L2h0bWwvY29tX25ld3NmZWVkcy9uZXdzZmVlZC9kZWZhdWx0LnBocA==', `extension_id`, 0, 'Joomla Update', `client_id`, CURRENT_TIMESTAMP(), CURRENT_TIMESTAMP()
  FROM `j3ux0_extensions`
 WHERE `name` = 'cassiopeia' AND `type` = 'template' AND `element` = 'cassiopeia' AND `client_id` = 0;

INSERT INTO `#__template_overrides` (`id`, `template`, `hash_id`, `extension_id`, `state`, `action`, `client_id`, `created_date`, `modified_date`)
SELECT 2, `name`, 'L2h0bWwvY29tX2NvbnRlbnQvYXJ0aWNsZS9kZWZhdWx0X2xpbmtzLnBocA==', `extension_id`, 0, 'Joomla Update', `client_id`, CURRENT_TIMESTAMP(), CURRENT_TIMESTAMP()
  FROM `j3ux0_extensions`
 WHERE `name` = 'cassiopeia' AND `type` = 'template' AND `element` = 'cassiopeia' AND `client_id` = 0;

After that, I went to the Home Dashboard in backend so the Overrides Check were run.

Then I had 2 changed override files.

Selecting one or both files and changing the "checked" status with the action from the "... Check Overrides" dropdown action menu worked fine.

But toggling the status of one file by clicking the "Checked" icon did not work, even if the tooltip of that icon says it should work. I got the "No file selected" error message every time I clicked the icon.

avatar richard67 richard67 - change - 16 Apr 2023
Status New Confirmed
avatar richard67
richard67 - comment - 16 Apr 2023

Confirmed.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40393.

avatar richard67 richard67 - change - 16 Apr 2023
Title
[4.3 RC] Unable to mark updated override file as checked
[4.3 RC] Unable to toggle check status of a single updated override file using the "Checked" status icon
avatar richard67 richard67 - edited - 16 Apr 2023
avatar richard67
richard67 - comment - 16 Apr 2023

Closing as having a pull request. Please test #40397 . Thanks in advance.

avatar richard67 richard67 - change - 16 Apr 2023
Status Confirmed Closed
Closed_Date 0000-00-00 00:00:00 2023-04-16 22:17:49
Closed_By richard67
avatar richard67 richard67 - close - 16 Apr 2023
avatar Scrabble96
Scrabble96 - comment - 17 Apr 2023

I just tried to test this using the Patch Tester component and got this message:

"There are no files to patch from this pull request. This may mean that the files in the pull request are not present in your installation."

My overrides are in a custom template, not Cassiopeia

EDIT: Sorry - have also put this comment in the PR

avatar richard67
richard67 - comment - 17 Apr 2023

@Scrabble96 You can't test the PR with patchtester because it changes javascript sources. To rebuild the javascript it needs a development environment with NPM. Or you use the patch package or custom update URL created by Drone for that PR.

Add a Comment

Login with GitHub to post a comment