? PR-4.3-dev Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
10 Apr 2023

The code comments here do not make sense. I have attempted to correct that but I am not 1000% certain I have understood it correctly. Happy to correct it further.

There is no point in having a comment in the code if it doesn't make sense

cc @laoneo @HLeithner @obuisard

avatar joomla-cms-bot joomla-cms-bot - change - 10 Apr 2023
Category Libraries
avatar brianteeman brianteeman - open - 10 Apr 2023
avatar brianteeman brianteeman - change - 10 Apr 2023
Status New Pending
avatar brianteeman brianteeman - change - 10 Apr 2023
Labels Added: PR-4.3-dev
avatar richard67 richard67 - test_item - 10 Apr 2023 - Tested successfully
avatar richard67
richard67 - comment - 10 Apr 2023

I have tested this item successfully on 9be303b

Review


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40360.

avatar Quy Quy - test_item - 11 Apr 2023 - Tested successfully
avatar Quy
Quy - comment - 11 Apr 2023

I have tested this item successfully on 9be303b


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40360.

avatar Quy Quy - change - 11 Apr 2023
Status Pending Ready to Commit
avatar Quy
Quy - comment - 11 Apr 2023

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40360.

avatar laoneo laoneo - change - 5 May 2023
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2023-05-05 13:32:15
Closed_By laoneo
Labels Added: ?
avatar laoneo laoneo - close - 5 May 2023
avatar laoneo laoneo - merge - 5 May 2023
avatar laoneo
laoneo - comment - 5 May 2023

Thanks!

avatar brianteeman
brianteeman - comment - 5 May 2023

thx

Add a Comment

Login with GitHub to post a comment