[#40353] - [4.3] Disabled menu items
- Fixed in Code Base
- 6 May 2023
- Medium
- Build: 4.3-dev
- # 40353
- Diff
- brianteeman:component_disabled
User tests: Successful: Unsuccessful:
Pull Request for Issue #19874 (yes it's an old one) .
If you have a menu item to a disabled or uninstalled component then it is displayed as unpublished. This is not correct as the menu link is still displayed on the site and causes confusion as seen in the original report.
Summary of Changes
Display a warning icon instead of an unpublished icon.
Remove the clickable action on the icon which can't do anything
Use the correct tooltip
Testing Instructions
Install any 2 components and create a menu item for each.
Disable component1 in the extension manager
Uninstall component2 from the extension manager
Actual result BEFORE applying this Pull Request
Not shown in the screenshot but the icon is clickable
Expected result AFTER applying this Pull Request
Not shown in the screenshot but the icon is not clickable
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
joomla-cms-bot
- | Category | ⇒ | Administration com_menus |
| Status | New | ⇒ | Pending |
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40353.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40353.
We would have loved to see this in 4.3. However, we are now in the bug fixing period with the version.
This is a great enhancement, improves UX/UI with appropriate language and icon.
This is why I have tagged it for 5.0.
This is a bug fix for a five year old bug report- its not a new feature.
This is a bug fix for a five year old bug report- its not a new feature.
I revised it once more. You are right, this is a bug.
| Labels |
Added:
?
bug
PR-4.3-dev
|
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2023-05-06 20:37:05 |
| Closed_By | ⇒ | obuisard |
Thank you Brian @brianteeman for the PR. That was an old one indeed!
thanks for reconsidering
Of course! Thanks to you.
I have tested this item✅ successfully on 512b04a
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40353.