[#40343] - Replace JPATH_PLATFORM with _JEXEC
- Fixed in Code Base
- 29 May 2023
- Medium
- Build: 4.4-dev
- # 40343
- Diff
- Digital-Peak:plaform/remove
- Pending continuous-integration/drone/pr Build is pending Details
User tests: Successful: Unsuccessful:
Replaces JPATH_PLATFORM with _JEXEC as JPATH_PLATFORM. Like that we have one way to check if the CMS is loaded correctly.
joomla-cms-bot
- | Category | ⇒ | Administration com_admin com_banners com_categories com_config com_contact com_content com_fields com_finder com_installer com_languages com_menus com_messages com_modules com_newsfeeds com_redirect com_tags com_templates com_users Repository Front End |
| Status | New | ⇒ | Pending |
Surely this is a breaking change
What does break? Happy to solve any bc issues.
| Labels |
Added:
PR-4.4-dev
|
||
What to do with this? Consequences? Depreceated?
Line 22 in a517383
Line 28 in a517383
joomla-cms/libraries/import.legacy.php
Line 21 in a517383
joomla-cms/libraries/import.php
Line 21 in a517383
These must stay for backwards compatibility.
What does break? Happy to solve any bc issues.
Any tool that people have written to check for the presence of the check will fail.
The check should still work as the defines are still in place. @sandewt pointed them out in his last comment. Only the occurrences in the CMS code are changed.
it is those occurences I am referring to.
this is a disruptive change for zero benefit and should definitely not be made in a minor release
So you agree that it is not a bc break?
This was proposed in the past and we agreed things in the libraries folder was a b/c break because there were concrete examples of cli apps (in the j3 format) even on our own joomla.org sites defining JPATH_PLATFORM instead of JEXEC.
So yes it's a b/c break. You should be fine with the changes in the administrator folder however.
To be clear I'm a
I can't really imagine how you can run joomla 4 without jexec so I wouldn't count this as break. But I do also have no issue to rebase to 5. For me is more important that we get rid of inconsistency.
| Category | Administration com_admin com_banners com_categories com_config com_contact com_content com_fields com_finder com_installer com_languages com_menus com_messages com_modules com_newsfeeds com_redirect com_tags com_templates com_users Repository Front End | ⇒ | Administration com_admin SQL Postgresql com_banners com_categories com_config com_contact com_content com_fields com_finder |
| Category | Administration com_admin com_banners com_categories com_config com_contact com_content com_fields com_finder SQL Postgresql | ⇒ | Administration com_admin com_banners com_categories com_config com_contact com_content com_fields com_finder com_installer com_languages com_menus com_messages com_modules com_newsfeeds com_redirect com_tags com_templates com_users Repository Front End |
| Labels |
Added:
PR-5.0-dev
|
||
Is there something documented about this vote? I'm not aware of any discussion.
I've not been in the meetings since 4.0 finished (so 1.5 years now) but https://volunteers.joomla.org/departments/production/reports/1793-production-dept-meeting-minutes-august-23-2022 was the motion i understood to have been approved which is deprecation for two major versions before removal hence #38657 being merged which was 99% of the originally intended 5.0 deprecations going back to 6.0
You was talking before about that PLATFORM should not be deprecated issue. The 2 years policy I'm aware of.
| Labels |
Added:
b/c break
Removal
Removed: PR-4.4-dev |
||
Did the sync, but not sure what you want for a notice where?
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2023-05-29 08:12:14 |
| Closed_By | ⇒ | HLeithner |
Thanks
What to do with this? Consequences? Depreceated?
joomla-cms/libraries/cms.php
Line 22 in a517383
joomla-cms/libraries/cms.php
Line 28 in a517383
joomla-cms/libraries/import.legacy.php
Line 21 in a517383
joomla-cms/libraries/import.php
Line 21 in a517383