[#40332] - [4.3] Fix dynamic properties warnings on Multilinual Sample Data plugin
- Fixed in Code Base
- 6 May 2023
- Medium
- Build: 4.3-dev
- # 40332
- Diff
- joomdonation:sample_data_dynamic_properties
User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Summary of Changes
This PR fixes Creation of dynamic property warnings on Multilinual Sample Data plugin on PHP 8.2. We assign return values of two methods two none-existent properties and PHP 8.2 throws warnings. I found this issue while testing PR #40216
As these properties are not used at all inside the plugin (you can scan code to confirm), we can just return the values directly.
Testing Instructions
- Use Joomla 4.3 night build on PHP 8.2
- Set Error Reporting to Maximum
- Install an extra language (to setup multilingual website)
- Install Multilinual Sample Data
Code review should also be enough.
Actual result BEFORE applying this Pull Request
There is an error with set up sample data. The process could not be finished
Expected result AFTER applying this Pull Request
No error. Sample data property installed.
Link to documentations
Please select:
- No documentation changes for docs.joomla.org needed
- No documentation changes for manual.joomla.org needed
joomla-cms-bot
- | Category | ⇒ | Front End Plugins |
| Status | New | ⇒ | Pending |
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40332.
| Status | Pending | ⇒ | Ready to Commit |
| Labels |
Added:
PR-4.3-dev
|
||
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40332.
Test OK. Solved my issue .
| Labels |
Added:
?
bug
|
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2023-05-06 00:22:56 |
| Closed_By | ⇒ | obuisard |
Thank you Tuan @joomdonation :-)
I have tested this item✅ successfully on 5c867f4
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40332.