? PR-4.3-dev Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
3 Apr 2023

You can't have two buttons with the same text that do different things. I am assuming that this change was made in error by @wilsonge in #39537

Joomla 4.29

image

Joomla 4.3 before this PR

image

Joomla 4.3 after this PR

image

Pull Request for Issue # .

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar joomla-cms-bot joomla-cms-bot - change - 3 Apr 2023
Category Administration com_installer
avatar brianteeman brianteeman - open - 3 Apr 2023
avatar brianteeman brianteeman - change - 3 Apr 2023
Status New Pending
avatar brianteeman brianteeman - change - 3 Apr 2023
The description was changed
avatar brianteeman brianteeman - edited - 3 Apr 2023
avatar Quy Quy - test_item - 3 Apr 2023 - Tested successfully
avatar Quy
Quy - comment - 3 Apr 2023

I have tested this item successfully on 98105dc


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40323.

avatar viocassel viocassel - test_item - 3 Apr 2023 - Tested successfully
avatar viocassel
viocassel - comment - 3 Apr 2023

I have tested this item successfully on 98105dc


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40323.

avatar Quy Quy - change - 3 Apr 2023
Status Pending Ready to Commit
Labels Added: PR-4.3-dev
avatar Quy
Quy - comment - 3 Apr 2023

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40323.

avatar Quy Quy - change - 3 Apr 2023
Labels Added: ?
avatar wilsonge
wilsonge - comment - 3 Apr 2023

Yup looking at it I'd assume I made a mess of it too. Thanks!

avatar wilsonge wilsonge - change - 3 Apr 2023
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2023-04-03 23:09:49
Closed_By wilsonge
avatar wilsonge wilsonge - close - 3 Apr 2023
avatar wilsonge wilsonge - merge - 3 Apr 2023

Add a Comment

Login with GitHub to post a comment