[#40319] - [4.3] Guided Tours use global language keys
- Fixed in Code Base
- 4 Apr 2023
- Medium
- Build: 4.3-dev
- # 40319
- Diff
- heelc29:4.3/com_guidedtours/lang-global
User tests: Successful: Unsuccessful:
Summary of Changes
use the global strings for "Status" and "ID" in heading of tours/steps lists (they are already used in edit form and for sorting)
@obuisard Should the language keys deprecated or removed?
Note: Title and Description is also inconsistent
Testing Instructions
check the used language key
Actual result BEFORE applying this Pull Request
Tour
Step
Expected result AFTER applying this Pull Request
Tour
Step
Link to documentations
Please select:
- No documentation changes for docs.joomla.org needed
- No documentation changes for manual.joomla.org needed
joomla-cms-bot
- | Category | ⇒ | Administration Language & Strings |
| Status | New | ⇒ | Pending |
Surely there is no need to deprecate these strings and they can just be deleted as the code has not been released
yes please let's do things simply., delete without deprecations there's no need to over-engineer in this case, imho
| Labels |
Added:
Language Change
PR-4.3-dev
|
||
@brianteeman @alikon deleted
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40319.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40319.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40319.
| Labels |
Added:
?
|
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2023-04-04 14:55:41 |
| Closed_By | ⇒ | obuisard |
I believe the language keys should be deprecated.