[#40310] - [5.0] Removing erroneous User::aid attribute
- Fixed in Code Base
- 1 Jul 2023
- Medium
- Build: 4.3-dev
- # 40310
- Diff
- Hackwar:4.3-user-aid
User tests: Successful: Unsuccessful:
Summary of Changes
In Joomla 4.2.7, this attribute was added into the User class because a notice was thrown in PHP 8.2. This notice comes from a line of code which had been forgotten to remove in Joomla 1.6. https://github.com/joomla/joomla-cms/blob/3.10-dev/libraries/src/User/User.php#L255 This attribute was present in Joomla 1.5, but has been removed in Joomla 1.6, while that one line has remained throughout time. We are not filling that attribute with anything since then and instead of removing that line, that attribute was added back in instead.
For the mother of god and everything that is good and holy, can we PLEASE remove this right here and right now, before Joomla 4.3.0 is released without making a big fuss about this? I will literally go crazy if we have to pull this through to Joomla 6.0 now, just because the initial PR (#39620) was not checked properly. Yes, we have deprecation rules, but there are exemptions.
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
joomla-cms-bot
- | Category | ⇒ | Libraries |
| Status | New | ⇒ | Pending |
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40310.
@Hackwar You missed one more in __wakeup
joomla-cms/libraries/src/User/User.php
Line 870 in c56fd16
I am fine here, with removing.
But for compromise, we can rremove all instances of $this->aid = 0, and mark aid property as deprecated in 4.4, and remove in 5.0
| Labels |
Added:
PR-4.3-dev
|
||
I removed it from __wakeup.
It is an attribute which has no functionality and has been added in a patch release. Can we PLEASE stop this before people have 2 minor releases time to find stupid ways to use this?
if you like to discuss out b/c policy then please do so but not in the past, thanks...
Removing in 5.0 is ok for me
of course but even on 4.3 is ok for me too
it's from 1.5/6 so.....
| Labels |
Added:
bug
|
||
| Title |
|
||||||
| Labels |
Added:
PR-5.0-dev
Removed: PR-4.3-dev |
||
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2023-07-01 10:30:22 |
| Closed_By | ⇒ | HLeithner |
thanks
I do agree that it should be a shame on us that we didn't remove this line which sets that property in all those years. But we have a BC policy and I'm in favor to follow it and remove the property not before 6.0.