Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#40299] - [4.3] Guided Tours improvement search label

? Language Change bug PR-4.3-dev Pending

User tests: Successful: Unsuccessful:

avatar heelc29
heelc29
2 Apr 2023

Summary of Changes

More meaningful label of search field for tours and step link e.g. for articles:

joomla-cms/administrator/language/en-GB/com_content.ini

Line 110 in 04b9ee8

COM_CONTENT_FILTER_SEARCH_LABEL="Search Articles"

Testing Instructions

Check label of search input for tours and steps

<div class="input-group">
    <input type="text" name="filter[search]" id="filter_search" value="" class="form-control" aria-describedby="filter_search-desc" placeholder="Search" inputmode="search">
    <div role="tooltip" id="filter_search-desc" class="filter-search-bar__description">
        Search in title. Prefix with ID: to search for a tour ID or DESCRIPTION: to search in description.
    </div>
    <span class="filter-search-bar__label visually-hidden">
        <label id="filter_search-lbl" for="filter_search">
            Search Tours
        </label>
    </span>
    <button type="submit" class="filter-search-bar__button btn btn-primary" aria-label="Search">
        <span class="filter-search-bar__button-icon icon-search" aria-hidden="true"></span>
    </button>
</div>

Link to documentations

Please select:

  • No documentation changes for docs.joomla.org needed
  • No documentation changes for manual.joomla.org needed
avatar joomla-cms-bot joomla-cms-bot - change - 2 Apr 2023
Category ⇒ Administration Language & Strings
avatar heelc29 heelc29 - open - 2 Apr 2023
avatar heelc29 heelc29 - change - 2 Apr 2023
Status New ⇒ Pending
avatar Quy Quy - test_item - 2 Apr 2023 - Tested successfully
avatar Quy
Quy - comment - 2 Apr 2023

I have tested this item ✅ successfully on 945512f

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40299.

avatar khu5h1 khu5h1 - test_item - 3 Apr 2023 - Tested successfully
avatar khu5h1
khu5h1 - comment - 3 Apr 2023

I have tested this item ✅ successfully on 945512f

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40299.

avatar richard67 richard67 - change - 3 Apr 2023
Status Pending ⇒ Ready to Commit
Labels Added: Language Change PR-4.3-dev
avatar richard67
richard67 - comment - 3 Apr 2023

RTC

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40299.

avatar obuisard obuisard - change - 6 May 2023
Labels Added: ? bug
avatar obuisard obuisard - change - 6 May 2023
Status Ready to Commit ⇒ Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 ⇒ 2023-05-06 20:08:37
Closed_By ⇒ obuisard
avatar obuisard obuisard - close - 6 May 2023
avatar obuisard obuisard - merge - 6 May 2023
avatar obuisard
obuisard - comment - 6 May 2023

Thanks @heelc29 :-)

Add a Comment

Login with GitHub to post a comment