Joomla! Issue Tracker | Joomla! CMS #40272

? PR-4.3-dev

Fixed in Code Base
31 Mar 2023
Medium
Build: 4.3-dev
# 40272
Diff
heelc29:4.3/com_redirect/layout/batch

Pending

User tests: Successful: Unsuccessful:

heelc29
31 Mar 2023

Follow up Pull Request #38328 .

Summary of Changes

class \Joomla\CMS\Factory\Factory do not exist

Testing Instructions

copy following code

// Instantiate a new FileLayout instance and render the batch button
$layout = new \Joomla\CMS\Layout\FileLayout('toolbar.batch');
$dhtml  = $layout->render(['title' => Text::_('JTOOLBAR_BULK_IMPORT')]);
$toolbar->appendButton('Custom', $dhtml, 'batch');

an put it here because the layout is no longer used in joomla core

joomla-cms/administrator/components/com_redirect/src/View/Links/HtmlView.php

Lines 206 to 210 in 280c0b8

    
           if ($canDo->get('core.create')) { 
        
               $toolbar->popupButton('batch', 'JTOOLBAR_BULK_IMPORT') 
        
                   ->selector('collapseModal') 
        
                   ->listCheck(false); 
        
           }

now visit /administrator/index.php?option=com_redirect

Actual result BEFORE applying this Pull Request

Expected result AFTER applying this Pull Request

Link to documentations

Please select:

No documentation changes for docs.joomla.org needed
No documentation changes for manual.joomla.org needed

db10079 31 Mar 2023

[4.3] fix factory class

joomla-cms-bot - change - 31 Mar 2023

Category

⇒

Administration com_redirect

heelc29 - open - 31 Mar 2023

heelc29 - change - 31 Mar 2023

Status

New

⇒

Pending

Quy - test_item - 31 Mar 2023 - Tested successfully

Quy - comment - 31 Mar 2023

I have tested this item ✅ successfully on db10079

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40272.}

alikon - test_item - 31 Mar 2023 - Tested successfully

alikon - comment - 31 Mar 2023

I have tested this item ✅ successfully on db10079

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40272.}

alikon - change - 31 Mar 2023

Status

Pending

⇒

Ready to Commit

alikon - comment - 31 Mar 2023

RTC

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40272.}

obuisard - change - 31 Mar 2023

Status	Ready to Commit	⇒	Fixed in Code Base
Closed_Date	0000-00-00 00:00:00	⇒	2023-03-31 19:59:06
Closed_By		⇒	obuisard
Labels	Added: ? PR-4.3-dev

obuisard - close - 31 Mar 2023

obuisard - merge - 31 Mar 2023

obuisard - comment - 31 Mar 2023

Thank you @heelc29 for the fix!

Add a Comment

Older
Newer

Joomla! Issue Tracker - CMS

[#40272] - [4.3] fix factory class

Summary of Changes

Testing Instructions

Actual result BEFORE applying this Pull Request

Expected result AFTER applying this Pull Request

Link to documentations

Add a Comment

	if ($canDo->get('core.create')) {
	$toolbar->popupButton('batch', 'JTOOLBAR_BULK_IMPORT')
	->selector('collapseModal')
	->listCheck(false);
	}