[#4027] - Google API isn't a requirement.
- Closed
- 27 Oct 2014
- Medium
- Build: staging
- # 4027
- Diff
- bweston92:patch-1
- Failure The Travis CI build failed Details
User tests: Successful: Unsuccessful:
https://developers.google.com/maps/signup?csw=1
Reading the Google Maps v3 which Joomla uses doesn't require a key at all.
Oops sorry will do when at computer, rushing on GitHub editor aha—
Sent from Mailbox for iPhone
On Mon, Jul 28, 2014 at 7:17 PM, George Wilson notifications@github.com
wrote:
Hi,
Thanks for submitting this code :) Could you please correct line 595 as
$callbackisn't defined - think you meant to pass in$asynccallback?Reply to this email directly or view it on GitHub:
#4027 (comment)
nicksavov
- | Labels |
Removed:
?
|
||
brianteeman
- | Status | New | ⇒ | Pending |
| Category | ⇒ | External Library |
It would be helpful to have test instructions please?
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/4027.
@bweston92 can you resolove the conflicts and rebase? Some of the changes are allready made #4167. Thanks
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/4027.
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2014-10-27 08:35:55 |
Hi,
Thanks for submitting this code :) Could you please correct line 595 as
$callbackisn't defined - think you meant to pass in$asynccallback?