? Success

User tests: Successful: Unsuccessful:

avatar ghost
ghost
28 Jul 2014

See my comment at
de92ca5
due to
#3182

Votes

# of Users Experiencing Issue
1/1
Average Importance Score
3.00

avatar illovo illovo - open - 28 Jul 2014
avatar illovo illovo - reference | - 28 Jul 14
avatar Bakual
Bakual - comment - 28 Jul 2014

Please don't refer to some comment. Put all the relevant information into your Pull Request and also testing instructions so it can be tested.

avatar illovo
illovo - comment - 29 Jul 2014

This issue was mentioned by Victor Vogel at
http://joomlacode.org/gf/project/joomla/tracker/?action=TrackerItemEdit&tracker_item_id=33910&start=0
but has nothing to do with original issue there and is not a WAMP or XAMPP issue.

Test (XAMPP and/or online):

Installation fails because of
[Content-Disposition] => attachment; filename=K2_v2.6.8.zip;
See semicolon at the end!

In tmp folder a file is created
K2_v2.6.8.zip;
See semicolon at the end!

So, JArchive::extract(...) fails because of unknown archive type zip;
See semicolon at the end!

Presence of semicolons in [Content-Disposition] was not discussed in #3182 , just quotes.

avatar Bakual
Bakual - comment - 29 Jul 2014

Thanks, I see now what you mean.

I wonder why getk2.org has a semicolon after the filename to begin with. Is that valid syntax according to RFCs? The examples I found all either quote the filename or just put the filename without any quotes. I didn't see an example ending the filename with a semicolon.

I just want to rule out it's not a bug in getk2.org itself.

avatar chrisdavenport
chrisdavenport - comment - 29 Jul 2014

The semicolon is a valid separator character in the syntax of Content-Disposition headers. As such, it should not be considered part of the filename.

See: http://tools.ietf.org/html/rfc6266

avatar Bakual
Bakual - comment - 29 Jul 2014

@chrisdavenport & @illovo Thanks for the explanations.

I could reproduce the problem using the webinstaller and trying to install K2. PR fixes the issue.
Also code looks fine.

avatar Bakual Bakual - change - 10 Aug 2014
Status New Closed
Closed_Date 0000-00-00 00:00:00 2014-08-10 19:42:56
avatar Bakual Bakual - close - 10 Aug 2014

Add a Comment

Login with GitHub to post a comment