[#40235] - 4.3 dev issue with the navigation menu
- Closed
- 31 Mar 2023
- Medium
- Build: 4.3-dev
- # 40235
- Diff
- joomla:4.4-dev
- Success Download Prebuilt packages are available for download. Details
- Success continuous-integration/appveyor/branch AppVeyor build succeeded Details
- Success continuous-integration/drone/push Build is passing Details
- Pending continuous-integration/drone/pr Build is pending Details
User tests: Successful: Unsuccessful:
Pull Request for Issue #37926
Issue with navigation menu and breakpoints
Clean installation of joomla 4.1.4 without any changes.
I noticed that on screens with resolutions between 768px (medium) and 992px (large), the navigation menu does not collapse to hamburger menu.
so i have change the bootstrap class it will automatically turn into a hamburger menu at smaller screen
related to #37926
Summary of Changes
After changing the class now the nav is responsive
Actual result BEFORE applying this Pull Request
No hamburger menu is created
Expected result AFTER applying this Pull Request
Automatically hamburger menu will created when screen size is reduced
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
joomla-cms-bot
- | Category | ⇒ | Unit Tests Repository Administration com_admin com_config com_content com_contenthistory com_installer com_joomlaupdate com_postinstall com_templates Language & Strings Front End External Library Composer Change |
| Status | New | ⇒ | Pending |
| Title |
|
||||||
| Labels |
Added:
?
Language Change
Composer Dependency Changed
PR-4.3-dev
|
||
| Category | Unit Tests Repository Administration com_admin com_config com_content com_contenthistory com_installer com_joomlaupdate com_postinstall com_templates Language & Strings Front End External Library Composer Change | ⇒ | Unit Tests Repository Administration com_admin com_config com_content com_contenthistory com_installer com_joomlaupdate com_postinstall com_templates Language & Strings Front End |
wilsonge
- | Labels |
Removed:
Composer Dependency Changed
|
||
| Title |
|
||||||
@Mohammadkhan18 Can it be that you have made this PR for the wrong branch? It is made against the 4.3-dev branch of the CMS but from the 4.4-dev branch of your repo, and it shows all differences between 4.4-dev and 4.3-dev, too, when you check the changes of your PR on GitHub. So I think you should change the base branch. You can do that by using the "Edit" button right beside the title of your PR on GitHub.
And does your PR solve issue #37926 ? If so, please change the
Pull Request for Issueat the top of the description of your PR toPull Request for Issue #37926(including the space after the number) so that it is clear.Thanks in advance.
Yeah I have tried changing my base to 4.4 but doesn't allowing me to do that
Yeah I have tried changing my base to 4.4 but doesn't allowing me to do that
@Mohammadkhan18 I see. That's because you have used your 4.4-dev branch for that PR. Could you create a new branch based on the 4.4-dev branch and then do your changes again and make a new PR? You can find here some information on how to use GitHub to do that: https://docs.joomla.org/Using_the_Github_UI_to_Make_Pull_Requests . Thanks in advance.
Oh ok thank you
I hope I get selected in joomla because it's community looking awesome
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2023-03-31 01:35:14 |
| Closed_By | ⇒ | Mohammadkhan18 |
@Mohammadkhan18 Can it be that you have made this PR for the wrong branch? It is made against the 4.3-dev branch of the CMS but from the 4.4-dev branch of your repo, and it shows all differences between 4.4-dev and 4.3-dev, too, when you check the changes of your PR on GitHub. So I think you should change the base branch. You can do that by using the "Edit" button right beside the title of your PR on GitHub.
And does your PR solve issue #37926 ? If so, please change the
Pull Request for Issueat the top of the description of your PR toPull Request for Issue #37926(including the space after the number) so that it is clear.Thanks in advance.