[#40232] - [4.4] Replace JPATH_PLATFORM with _JEXEC in plugin code
- Fixed in Code Base
- 29 Mar 2023
- Medium
- Build: 4.4-dev
- # 40232
- Diff
- sandewt:patch-10
User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Summary of Changes
The constant JPATH_PLATFORM is a history thing and should not be used in the plugin code
This pr replaces this with _JEXEC , and makes the code consistent with that of the other plugins.
Related to #39997
Testing Instructions
- Works
- Code review
Actual result BEFORE applying this Pull Request
Code: \defined('JPATH_PLATFORM') or die;
Expected result AFTER applying this Pull Request
Code: \defined('_JEXEC') or die;
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
@laoneo please take a look
joomla-cms-bot
- | Category | ⇒ | Front End Plugins |
| Status | New | ⇒ | Pending |
Just wondering, do we have more occurrences of JPATH_PLATFORM or are these the last ones?
I have checked the plugin code in Joomla 4.4. The modules (site) are up to date.
I assume the libraries folder is not applicable. Is this correct?
If yes, then there are still about 24 in the folder \administrator\components...
Good idea, looks ok to me
So we can do in a followup pr a replacement of all JPATH_PLATFORM...
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2023-03-29 13:25:14 |
| Closed_By | ⇒ | laoneo | |
| Labels |
Added:
PR-4.4-dev
|
||
Thanks!
Thanks all
Just wondering, do we have more occurrences of JPATH_PLATFORM or are these the last ones?