[#40228] - Guided tours removal of tour permissions
- Fixed in Code Base
- 31 Mar 2023
- Medium
- Build: 4.3-dev
- # 40228
- Diff
- obuisard:guided-tours-permissions
- Pending continuous-integration/drone/pr Build is pending Details
User tests: Successful: Unsuccessful:
Pull Request as a replacement for #40208 and #40220. It compiles some of the corrections made and simplifies the code.
Summary of Changes
Individual tours have permissions in the original Guided Tours PR.
However, tours don't really require such granularity in most cases and the issues linked to having tours in the asset table outweighs the need for such permissions.
This PR removes permissions for individual tours.
Testing Instructions
Ideally, create several user profiles with limited permissions and make sure those having limited permissions can't access the functionality they are denied.
Actual result BEFORE applying this Pull Request
Tours can have individual permissions
Expected result AFTER applying this Pull Request
Tours and steps only get the general permissions of the component.
Link to documentations
Please select:
-
Documentation link for docs.joomla.org: need to remove the permissions section for tours at Guided Tours: New or Edit Tour
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
joomla-cms-bot
- | Category | ⇒ | SQL Administration com_admin Postgresql Installation |
| Status | New | ⇒ | Pending |
| Labels |
Added:
PR-4.3-dev
|
||
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40228.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40228.
| Labels |
Added:
?
|
||
sdwjoomla
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2023-03-31 22:03:02 |
| Closed_By | ⇒ | sdwjoomla |
I have tested this item✅ successfully on 99f68b1
Tested new installation, tested update, it is still working well. Try to edit tours, steps, all still work. Did a quick code review, too
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40228.