Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#4022] - [#34009] Render checkboxes and radio button fields with layout

? ? Success

User tests: Successful: Unsuccessful:

avatar okonomiyaki3000
okonomiyaki3000
28 Jul 2014

Tracker is here: http://joomlacode.org/gf/project/joomla/tracker/?action=TrackerItemEdit&tracker_item_id=34009&start=0

How to reproduce the problem and/or test the patch::
Using Isis or any other Bootstrap-based template, have a look at a form with a 'checkboxes' field. The spacing and positioning is just not right.
Successful Tests:
Easy:
Summary
Checkboxes badly rendered with bootstrap
Details

The proper way to do checkboxes in Bootstrap is to wrap the input tag inside the label and give the label (not the input) the class 'checkbox'. When doing it this way, the label does not need a 'for' attribute and the input does not need an id. The label is automatically associated with an input that it wraps.

I suppose radio buttons should also be done this way.

avatar okonomiyaki3000 okonomiyaki3000 - open - 28 Jul 2014
avatar okonomiyaki3000 okonomiyaki3000 - change - 28 Jul 2014
Labels
avatar okonomiyaki3000 okonomiyaki3000 - change - 28 Jul 2014
Labels Added: ?
avatar okonomiyaki3000 okonomiyaki3000 - change - 28 Jul 2014
Title
…
Render checkboxes and radio button fields with layout
[#34009] Render checkboxes and radio button fields with layout
avatar nicksavov nicksavov - change - 21 Aug 2014
Labels
avatar brianteeman brianteeman - change - 21 Aug 2014
Status New ⇒ Pending
avatar nicksavov nicksavov - change - 21 Aug 2014
Labels Removed: ?
avatar brianteeman brianteeman - change - 2 Sep 2014
Category ⇒ Layout
avatar okonomiyaki3000
okonomiyaki3000 - comment - 20 Nov 2014

:recycle:

avatar designbengel
designbengel - comment - 7 Jun 2015

so is this patch already merged? becaue before apply the checkboxes are shown in /administrator/index.php?option=com_templates&view=style&layout=edit&id=7 like you described in the tracker...

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/4022.

avatar okonomiyaki3000
okonomiyaki3000 - comment - 8 Jun 2015

@designbengel No, unbelievably, this has still not been merged. The checkboxes you are talking about (I guess on the assignment tab) are not rendered with JForm, they're done directly in the template file. The purpose of this patch is to make JForm's rendering work more flexibly. Anyway, thanks for reminding me about this PR. I've now rebased it and made a minor change to modernize it a little. It should merge without issue and is kind of an obvious improvement.

avatar roland-d roland-d - change - 24 Aug 2015
The description was changed
avatar roland-d
roland-d - comment - 24 Aug 2015

I have tested this and it looks good. Here is how I tested it:
1. Find the file plugins/user/profile/profiles/profile.xml
2. Add the code

<field type="checkboxes" name="somefield" label="Select Some Stuff">
   <option value="a" checked="true">A</option>
   <option value="b">B</option>
   <option value="c">C</option>
</field>
  1. Go to Extensions -> Plugins
  2. Find the user profile plugin and enable it
  3. Go to the Users -> Manage
  4. Edit a user
  5. Go to the Profile tab and see the alignment of the checkboxes
  6. Apply this PR
  7. Refresh the page and see the alignment of the checkboxes again
  8. The checkboxes are correctly aligned now
avatar roland-d roland-d - test_item - 24 Aug 2015 - Tested successfully
avatar zero-24 zero-24 - test_item - 24 Aug 2015 - Tested successfully
avatar zero-24 zero-24 - change - 24 Aug 2015
Status Pending ⇒ Ready to Commit
avatar zero-24
zero-24 - comment - 24 Aug 2015

Thanks to the test instructions @roland-d and for the fix @okonomiyaki3000! I have just tested it and it works good. --> RTC :smile:

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/4022.

avatar joomla-cms-bot joomla-cms-bot - change - 24 Aug 2015
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - change - 24 Aug 2015
Labels Added: ?
avatar zero-24 zero-24 - change - 25 Aug 2015
Milestone Added:
avatar Kubik-Rubik Kubik-Rubik - change - 3 Sep 2015
Milestone Added:
avatar Kubik-Rubik Kubik-Rubik - change - 3 Sep 2015
Milestone Removed:
avatar rdeutz rdeutz - reference | 47f4218 - 1 Oct 15
avatar rdeutz rdeutz - merge - 1 Oct 2015
avatar rdeutz rdeutz - close - 1 Oct 2015
avatar rdeutz rdeutz - change - 1 Oct 2015
Status Ready to Commit ⇒ Closed
Closed_Date 0000-00-00 00:00:00 ⇒ 2015-10-01 18:01:19
Closed_By ⇒ rdeutz
avatar okonomiyaki3000 okonomiyaki3000 - head_ref_deleted - 2 Oct 2015
avatar zero-24 zero-24 - change - 2 Oct 2015
Labels Removed: ?
avatar zero-24 zero-24 - change - 28 Oct 2015
Milestone
avatar zero-24 zero-24 - change - 28 Oct 2015
Milestone Added:
avatar zero-24 zero-24 - change - 28 Oct 2015
Milestone Added:
avatar zero-24 zero-24 - change - 28 Oct 2015
Milestone

Add a Comment

Login with GitHub to post a comment