? Language Change PR-4.3-dev Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
26 Mar 2023

The key used for the caption was incorrect resulting in an untranslated string.

Actual result BEFORE applying this Pull Request

image

Expected result AFTER applying this Pull Request

image

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar joomla-cms-bot joomla-cms-bot - change - 26 Mar 2023
Category Administration
avatar brianteeman brianteeman - open - 26 Mar 2023
avatar brianteeman brianteeman - change - 26 Mar 2023
Status New Pending
avatar richard67
richard67 - comment - 26 Mar 2023

@brianteeman The diff on GitHub shows a lot more changes than just the language string key.

avatar brianteeman
brianteeman - comment - 26 Mar 2023

@richard67 stupid ide - fixing

avatar brianteeman brianteeman - change - 26 Mar 2023
Labels Added: PR-4.3-dev
avatar Quy
Quy - comment - 26 Mar 2023

There isn't a language string for it, but this should be List of Steps.

avatar joomla-cms-bot joomla-cms-bot - change - 27 Mar 2023
Category Administration Administration Language & Strings
avatar brianteeman brianteeman - change - 27 Mar 2023
The description was changed
avatar brianteeman brianteeman - edited - 27 Mar 2023
avatar brianteeman
brianteeman - comment - 27 Mar 2023

There isn't a language string for it, but this should be List of Steps.

good spot - updated the pr now

avatar brianteeman brianteeman - change - 27 Mar 2023
Labels Added: Language Change
avatar Quy Quy - test_item - 27 Mar 2023 - Tested successfully
avatar Quy
Quy - comment - 27 Mar 2023

I have tested this item successfully on c734339


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40214.

avatar khu5h1 khu5h1 - test_item - 27 Mar 2023 - Tested successfully
avatar khu5h1
khu5h1 - comment - 27 Mar 2023

I have tested this item successfully on c734339


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40214.

avatar richard67 richard67 - change - 27 Mar 2023
Status Pending Ready to Commit
avatar richard67
richard67 - comment - 27 Mar 2023

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40214.

avatar Quy Quy - change - 27 Mar 2023
Labels Added: ?
avatar obuisard obuisard - change - 27 Mar 2023
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2023-03-27 17:03:25
Closed_By obuisard
avatar obuisard obuisard - close - 27 Mar 2023
avatar obuisard obuisard - merge - 27 Mar 2023
avatar obuisard
obuisard - comment - 27 Mar 2023

Thank you Brian @brianteeman !

Add a Comment

Login with GitHub to post a comment