[#40206] - [4.3] Tinymce - style previews
- Fixed in Code Base
- 5 May 2023
- Medium
- Build: 4.3-dev
- # 40206
- Diff
- brianteeman:tiny_p0review
User tests: Successful: Unsuccessful:
Pull Request for Issue #40079 .
Summary of Changes
Specify the atributes to be used when previewing a style. This prevents white text on a white background making the preview invisible.
Testing Instructions
Add the following class to media\system\css\editor.css or media\system\css\editor.min.css (depends if you have debug on
.white-text {
color: #fff;
}
Actual result BEFORE applying this Pull Request
You cannot see the class in the menu as its color of white is used in the preview and makes it invisible
Expected result AFTER applying this Pull Request
You can see the class as we don't preview colours in the menu
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
joomla-cms-bot
- | Category | ⇒ | Front End Plugins |
| Status | New | ⇒ | Pending |
thats not a good approach. As tinymce provide an option xpecifically for this then we should use it.
This is probably due to the fact that it was decided not to use the <BASE> header tag.
Since we see that using basic libraries such as TinyMCE causes path relativity errors.
Are there any plans to go back to the idea of using the <BASE> tag sometime in the future?
it is irrelevant. it is not the correct way to do this. when there is a documented api it should always be used. Especially when it is from a third party. Then you will know that if they change it you will need to update.
I meant in major versions a return to using the BASE tag, with new rules with new functions, with a new API
this is not the topic of this Pull Request. Every time you go off topic you delay the changes. I made this pull request because you asked for it. if you dont want it then I will simply close it and do something more interesting.
Thanks. I tested it. Excellent. Everything works.
I didn't want to delay. I am very grateful. I was interested about a general question.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40206.
| Status | Pending | ⇒ | Ready to Commit |
| Labels |
Added:
PR-4.3-dev
|
||
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40206.
| Labels |
Added:
?
bug
|
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2023-05-05 01:13:20 |
| Closed_By | ⇒ | obuisard |
Thanks Brian @brianteeman, great PR.
thx
Thanks Brian Teeman
@brianteeman I tested and also tried an alternative option. I added the image background style to the array.
Which may be relevant the same way as background-color.
We see that the background of the pictures will not be applied to the menu item, since the background of the picture has a relative path error. This may not be relevant. Since we don't use this style. But if we use the
background-colorstyle, then we need to use thebackground-imagestyle.And also, bravo, thank you. I was just going to search by myself.