PR-4.4-dev Pending

User tests: Successful: Unsuccessful:

avatar sandewt
sandewt
26 Mar 2023

Pull Request for Issue # .

Summary of Changes

Match code in some .xml files with what is most common in Joomla
Swap services to src

Testing Instructions

  • works
  • code review

Actual result BEFORE applying this Pull Request

Module(s)

<folder module="mod_example">src</folder>
<folder>services</folder>

Plugin(s)

<folder>services</folder>
<folder plugin="example">src</folder>

Expected result AFTER applying this Pull Request

Module(s)

<folder module="mod_example">services</folder>
<folder>src</folder>

Plugin(s)

<folder plugin="example">services</folder>
<folder>src</folder>

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar joomla-cms-bot joomla-cms-bot - change - 26 Mar 2023
Category Modules Front End Plugins
avatar sandewt sandewt - open - 26 Mar 2023
avatar sandewt sandewt - change - 26 Mar 2023
Status New Pending
avatar laoneo
laoneo - comment - 26 Mar 2023

Cool, I did it that way to have the folders in alpha order too.

avatar laoneo laoneo - change - 27 Mar 2023
Title
[4.4] Make code consistent, change <folder>services</folder> to <folder>src</folder>
[4.4] Make code consistent, change services to src
Labels Added: PR-4.4-dev
avatar laoneo laoneo - change - 28 Mar 2023
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2023-03-28 06:02:20
Closed_By laoneo
avatar laoneo laoneo - close - 28 Mar 2023
avatar laoneo laoneo - merge - 28 Mar 2023
avatar laoneo
laoneo - comment - 28 Mar 2023

Thanks!

Add a Comment

Login with GitHub to post a comment