No Code Attached Yet
avatar brianteeman
brianteeman
25 Mar 2023

Steps to reproduce the issue

try to change the permissions of a tour

Expected result

image

Actual result

image

System information (as much as possible)

Additional comments

avatar brianteeman brianteeman - open - 25 Mar 2023
avatar joomla-cms-bot joomla-cms-bot - change - 25 Mar 2023
Labels Added: No Code Attached Yet
avatar joomla-cms-bot joomla-cms-bot - labeled - 25 Mar 2023
avatar obuisard
obuisard - comment - 26 Mar 2023

It's the same as articles, once an article is created. I don't think there are missing permissions here.

avatar brianteeman
brianteeman - comment - 26 Mar 2023

Surely a better analogy would be with categories or workflows. Categories contain articles. Workflows contains stages, Tours contain stages.

avatar richard67
richard67 - comment - 26 Mar 2023

@brianteeman I think you mean steps. But the steps do not have assets.

avatar brianteeman
brianteeman - comment - 26 Mar 2023

ok let me try it another way.

How can I prevent someone from creating a new step.

With the current permission settings I can prevent them from deleting or editing a tour and as a consequence I have prevented them from deleting or editing a step.

BUT I can still create new steps in the tour. I should be able to prevent that

avatar obuisard
obuisard - comment - 27 Mar 2023

One thing though, if someone has no access to a tour, the steps should not be accessible from the tour list. That has to be fixed (apply the same access we apply to the title of the tour in the list to prevent edit).

image

Steps have no permissions because it was considered a tour and its steps are the same 'object'. Therefore, access to a tour should trickle down to its steps:
if one can edit a tour, one can edit its steps. If one can delete a tour, the steps are deleted, if one can create a tour, one can create its steps...

I understand now that we need those extra permissions (create/edit own)

The steps list page is missing access restrictions in case someone can just edit the URL to access a tour's steps (assuming we prevent the click on the step's count in the tour list).

A PR is getting created to address all those issues.

avatar richard67
richard67 - comment - 27 Mar 2023

Closing as having a pull request. Please test #40220 . Thanks in advance.

avatar richard67 richard67 - close - 27 Mar 2023
avatar richard67 richard67 - change - 27 Mar 2023
Status New Closed
Closed_Date 0000-00-00 00:00:00 2023-03-27 16:33:34
Closed_By richard67

Add a Comment

Login with GitHub to post a comment