Can you make this change also in the original LESS file (https://github.com/joomla/joomla-cms/blob/staging/media/jui/less/icomoon.less)?
And if you can run the generatecss.php script afterwards (https://github.com/joomla/joomla-cms/blob/staging/build/generatecss.php), it would be perfect. This will ensure that the templates will be updated with this change.

I have changed the LESS file, however I don't have php or Joomla installed using the github repo on my windows laptop nor have the repo on my unix host, so I cannot run /build/generatecss.php. Sorry.

I have made the same changes manually in the template css files that would have been made using LESS (and in IE7 js).

Could you please add some test instructions for this issue, and update this PR for current staging?

Test instructions:

1. Create a test page with HTML that displays the icon-ban-circle icon e.g. <i class="icon-ban-circle"></i>Icon-ban-circle.

2. View this page prior to implementing this fix - should be a minus sign without a circle around it.

3. Implement this fix.

4. View the page after implementing this fix and it should be a minus sign with a circle around it (as the name suggests).

(I cannot quite believe I have been asked to define a test case for something this obvious. I cannot quite believe that a change this trivial has taken 7 months for someone to do something about.)

I cannot quite believe I have been asked to define a test case for something this obvious.
I cannot quite believe that a change this trivial has taken 7 months for someone to do something about.

There might just be a correlation there. We require at least 2 tests per tracker item, when an item has no test instructions, a good chance it won't get tested. As for the 7 months, now you see why we have PBF events, to tackle these kind of things and in the future hopefully not have such old PRs floating around.

Patch works fine!

Works, thanks!