[#40172] - [5.2] Category Item count takes publish dates into account
- Pending
- Medium
- Build: 4.3-dev
- # 40172
- Diff
- hendrikbehncke:patch-1
- Pending continuous-integration/drone/pr Build is pending Details
User tests: Successful: Unsuccessful:
Summary of Changes
Item count on a category takes the publish_up and publish_down dates into account.
Actual result BEFORE applying this Pull Request
When setting a publish_down date in the past to unpublish an article the item count on a category will still count this article as published. And vice versa with a publish_up date in the future. The Categories view shows a different amount of articles than actually visible on the Category Blog view
Expected result AFTER applying this Pull Request
Categories view will show the exact number of articles published in a category.
joomla-cms-bot
- | Category | ⇒ | Libraries |
| Status | New | ⇒ | Pending |
It will frustrate a user: you will see X published articles but if you click the red counter and navigate to article list with &filter[published]=0 filter you will see no articles because they are actually published (#__content.state = 1).
Not a good idea. Either skip it or implement a separate counter of smth like "currently unpublished" items.
| Labels |
Added:
PR-4.3-dev
|
||
Hi @richard67, that could indeed be an issue.
Maybe passing the fields in the options in components/com_content/src/Service/Category.php could solve this?
Or alternatively people use 3rd party plugins to automatically update the published flag depending on the publish_up and publish_down dates.
This pull request has been automatically rebased to 4.4-dev.
| Title |
|
||||||
This pull request has been automatically rebased to 5.2-dev.
| Title |
|
||||||
Can we be really sure that all tables
$this->_tableused herejoomla-cms/libraries/src/Categories/Categories.php
Line 341 in 7c3d332
publish_upandpublish_downcolumns? If that table doesn't have these columns, we will get an SQL error about an unknown column when executing the SQL statement which is extended by this PR.