Language files...?

SITE\administrator\language\en-GB\plg_task_demotasks.ini
SITE\administrator\language\en-GB\plg_task_demotasks.sys.ini

What if a site is actually using it>?

What if a site is actually using it>?

We would need to check the sheduler table before i guess. Not sure whether we should actually do that with j4.4 but 5.0 and within j4.4 or 4.3 we alert the users of stuff we intent to remove by 5.0.

In practical terms i would say the impact is low but you are right it should be tested too.

The real world problem is that on a site that has enabled any of the demo tasks (to see what they did) simply removing the plugin will leave an orphaned record

Yes said record could be removed too but i personally would say thats something for 5.0 not 4.4.

Agree, the record should deleted as well.

Ah got confused looks like this PR is already against 5.0. ;)

Agree, the record should deleted as well.

The problem is that we really should not be removing something from a users site without their knowledge. They might, for example, be using one of those demo tasks as part of their own server monitoring.

They might, for example, be using one of those demo tasks as part of their own server monitoring.

How do you want to use it for monitoring? All this task does is to wait for the defined amount of time.

We need a documentation entry and this plugin in the documentation as example how to create a plugin like this?

What would you say to an own repository which can be used as source for automatically installing the plugin within the system tests?

@laoneo can you remove the sql files, so if the plugin exists from an update it still exists but no longer available on new installations?

@richard67 please keep this in mind when creating the deleted files array for j5 thanks

@richard67 please keep this in mind when creating the deleted files array for j5 thanks

It just needs to add the files to the list of exclusions here so it does not produce false alarms: https://github.com/joomla/joomla-cms/blob/5.0-dev/build/deleted_file_check.php#L63 . Will do so.

@laoneo can you remove the sql files, so if the plugin exists from an update it still exists but no longer available on new installations?

It doesn't need to remove any SQL files. The 4.x update SQL (among which are those which have added the task scheduler stuff) are already removed in 5.0-dev.

Update: Ah, I see, it needs to remove the update SQL in this PR so the plugin isn't deleted when updating.

Update 2: Not sure if it also needs to revert the removal from the ExtensionsHelper here https://github.com/joomla/joomla-cms/pull/40147/files#diff-45688fa5398ae3d4bab3daa80bc4d2ea4785370233b82a7326f9676f965ec9ebL311 so the plugin is still considered a core plugin when it still exists after an update.

@laoneo can you remove the sql files, so if the plugin exists from an update it still exists but no longer available on new installations?

It doesn't need to remove any SQL files. The 4.x update SQL (among which are those which have added the task scheduler stuff) are already removed in 5.0-dev.

Update: Ah, I see, it needs to remove the update SQL in this PR so the plugin isn't deleted when updating.

Update 2: Not sure if it also needs to revert the removal from the ExtensionsHelper here https://github.com/joomla/joomla-cms/pull/40147/files#diff-45688fa5398ae3d4bab3daa80bc4d2ea4785370233b82a7326f9676f965ec9ebL311 so the plugin is still considered a core plugin when it still exists after an update.

since it's no longer a core extensions I think it should be removed

since it's no longer a core extensions I think it should be removed

Agree. I just checked and we don't have weblinks or search in the extensions helper, which are similar cases.

@laoneo can you remove the sql files, so if the plugin exists from an update it still exists but no longer available on new installations?

I don't think this is a good idea as it is not maintained anymore and when we change something in the scheduler, it can break your site. There is really no need to have a demo plugin in core which can only do a sleep call.

@laoneo As my PR #40768 just has been merged into 5.0-dev: Could you update your branch for this PR here so it is up to date with that? I can then make a PR against your branch for your PR using the new method instead of the update SQL for uninstalling the old plugin. Thanks in advance.

Updated

@laoneo PR for you is Digital-Peak#30 .

motion for this removal was successful in production, @laoneo can you create a documentation entry on manual (b/c break)

motion for this removal was successful in production, @laoneo can you create a documentation entry on manual (b/c break)

Here we go joomla/Manual#132