? PR-4.4-dev Pending

User tests: Successful: Unsuccessful:

avatar sandewt
sandewt
17 Mar 2023

Pull Request for Issue # .

Summary of Changes

Rebuild plugin PageNavigation with new Joomla 4 structure
Replacing (some) deprecated classes

Testing Instructions

Code review
Just try to use it as usual

Actual result BEFORE applying this Pull Request

Plugin works

Expected result AFTER applying this Pull Request

Plugin works

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar joomla-cms-bot joomla-cms-bot - change - 17 Mar 2023
Category Front End Plugins
avatar sandewt sandewt - open - 17 Mar 2023
avatar sandewt sandewt - change - 17 Mar 2023
Status New Pending
avatar sandewt sandewt - change - 17 Mar 2023
Labels Added: PR-4.4-dev
avatar toivo toivo - test_item - 18 Mar 2023 - Tested successfully
avatar toivo
toivo - comment - 18 Mar 2023

I have tested this item successfully on 6564797

Tested successfully in Joomla 4.4.0-dev of 18 March using PHP 8.1.10


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40142.

avatar joomdonation joomdonation - test_item - 19 Mar 2023 - Tested successfully
avatar joomdonation
joomdonation - comment - 19 Mar 2023

I have tested this item successfully on ba76e94

Works well. Thanks!


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40142.

avatar joomdonation
joomdonation - comment - 19 Mar 2023

@toivo Could you please help testing this PR again? Thanks.

avatar sandewt
sandewt - comment - 19 Mar 2023

Related to #40146 to get consistent code

avatar toivo toivo - test_item - 20 Mar 2023 - Tested successfully
avatar toivo
toivo - comment - 20 Mar 2023

I have tested this item successfully on ba76e94

Tested successfully in Joomla 4.4.0-dev of 20 March using PHP 8.1.10


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40142.

avatar joomdonation joomdonation - change - 20 Mar 2023
Status Pending Ready to Commit
avatar joomdonation
joomdonation - comment - 20 Mar 2023

RTC. If decision is using $lang->_ method instead of Text::_, we can do a a separate PR to change plugin layoutfile.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40142.

avatar MacJoom MacJoom - change - 22 Mar 2023
Labels Added: ?
avatar sandewt
sandewt - comment - 22 Mar 2023

Slip of the pen, (last) correction in code ?

avatar MacJoom MacJoom - close - 23 Mar 2023
avatar MacJoom MacJoom - merge - 23 Mar 2023
avatar MacJoom MacJoom - change - 23 Mar 2023
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2023-03-23 20:12:34
Closed_By MacJoom

Add a Comment

Login with GitHub to post a comment