? a11y bug PR-4.3-dev ? Pending

User tests: Successful: Unsuccessful:

avatar chmst
chmst
16 Mar 2023

Pull Request for Issue #.

Summary of Changes

To be accessible a table must have a header.
See for examle this checklist: https://dequeuniversity.com/checklists/web/tables

Joomla provides a param show_headings for frontend tables. This removes the table header.

This PR sets the table header visually-hidden so it is still present for assistive technologies.

I open some similar PRs to make testing easier.

Testing Instructions

You need at least one contact
Make Menu Items for featured contacts and contact category
Set param table_headings in tab "list layouts" to "hide"
See the view and sourcecode ot the tables in frontend

Actual result BEFORE applying this Pull Request

There is no table heading visible, also in source code.

Expected result AFTER applying this Pull Request

There is no table heading visible, but it is in sourcecode with class="visually-hidden"
Make sure that the table heading is shown when table_headings is set to yes, as before.

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar joomla-cms-bot joomla-cms-bot - change - 16 Mar 2023
Category Front End com_contact
avatar chmst chmst - open - 16 Mar 2023
avatar chmst chmst - change - 16 Mar 2023
Status New Pending
avatar ChristineWk ChristineWk - test_item - 16 Mar 2023 - Tested successfully
avatar ChristineWk
ChristineWk - comment - 16 Mar 2023

I have tested this item successfully on 1aea3fe


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40139.

avatar ChristineWk
ChristineWk - comment - 16 Mar 2023

Before Patch - source code:
<caption class="visually-hidden">
After Patch:
<caption class="visually-hidden"> Contacts, </caption> <thead class="visually-hidden">

avatar Quy Quy - change - 16 Mar 2023
Labels Added: a11y PR-4.3-dev ?
avatar Quy Quy - test_item - 16 Mar 2023 - Tested successfully
avatar Quy
Quy - comment - 16 Mar 2023

I have tested this item successfully on 928f779


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40139.

avatar chmst
chmst - comment - 16 Mar 2023

Thanks for fixes @Quy

avatar ChristineWk ChristineWk - test_item - 16 Mar 2023 - Tested successfully
avatar ChristineWk
ChristineWk - comment - 16 Mar 2023

I have tested this item successfully on 928f779


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40139.

avatar Quy Quy - change - 16 Mar 2023
Status Pending Ready to Commit
avatar Quy
Quy - comment - 16 Mar 2023

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40139.

avatar obuisard obuisard - change - 4 May 2023
Labels Added: ? bug
avatar obuisard obuisard - change - 4 May 2023
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2023-05-04 23:04:01
Closed_By obuisard
avatar obuisard obuisard - close - 4 May 2023
avatar obuisard obuisard - merge - 4 May 2023
avatar obuisard
obuisard - comment - 4 May 2023

Thanks again, Christiane @chmst!

Add a Comment

Login with GitHub to post a comment