? bug PR-4.3-dev Pending

User tests: Successful: Unsuccessful:

avatar Fedik
Fedik
16 Mar 2023

Summary of Changes

The patch removes useless strpos() check.
This event is set up in AssetRegistry by class name already. Also it is not a system wide event, and never should be.

Testing Instructions

Apply patch, and check that the site works as before.

Actual result BEFORE applying this Pull Request

Works.

Expected result AFTER applying this Pull Request

Works.

Link to documentations

Please select:

  • No documentation changes for docs.joomla.org needed
  • No documentation changes for manual.joomla.org needed
avatar joomla-cms-bot joomla-cms-bot - change - 16 Mar 2023
Category Libraries
avatar Fedik Fedik - open - 16 Mar 2023
avatar Fedik Fedik - change - 16 Mar 2023
Status New Pending
avatar Fedik Fedik - change - 16 Mar 2023
The description was changed
avatar Fedik Fedik - edited - 16 Mar 2023
avatar joomdonation
joomdonation - comment - 16 Mar 2023

Tested and nothing is broken. But please remove the unused use statement

use Joomla\CMS\Event\WebAsset\WebAssetRegistryAssetChanged;
avatar Fedik
Fedik - comment - 16 Mar 2023

done

avatar Fedik Fedik - change - 16 Mar 2023
Labels Added: PR-4.3-dev
avatar toivo toivo - test_item - 16 Mar 2023 - Tested successfully
avatar toivo
toivo - comment - 16 Mar 2023

I have tested this item successfully on 048a4e9

Tested successfully in Joomla 4.3.0-beta5-dev of 16 March using PHP 8.1.10


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40133.

avatar joomdonation joomdonation - test_item - 17 Mar 2023 - Tested successfully
avatar joomdonation
joomdonation - comment - 17 Mar 2023

I have tested this item successfully on 048a4e9


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40133.

avatar joomdonation joomdonation - change - 17 Mar 2023
Status Pending Ready to Commit
avatar joomdonation
joomdonation - comment - 17 Mar 2023

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40133.

avatar obuisard obuisard - change - 4 May 2023
Labels Added: ? bug
avatar obuisard obuisard - change - 4 May 2023
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2023-05-04 19:25:02
Closed_By obuisard
avatar obuisard obuisard - close - 4 May 2023
avatar obuisard obuisard - merge - 4 May 2023
avatar obuisard
obuisard - comment - 4 May 2023

Thanks Fedir @Fedik !

Add a Comment

Login with GitHub to post a comment