[#40130] - [4.3] phpinfo disabled check
- Fixed in Code Base
- 4 May 2023
- Medium
- Build: 4.3-dev
- # 40130
- Diff
- brianteeman:phpinfo_disabled
- Pending continuous-integration/drone/pr Build is pending Details
User tests: Successful: Unsuccessful:
Pull Request for Issue #40125
Summary of Changes
Removes any spaces from the disable_functions string in the php.ini before exploding into an array for checking
Testing Instructions
in your php.ini file add the following line and restart apache
disable_functions = show_source, system, shell_exec, passthru, exec, phpinfo, popen, proc_open
then go to the joomla system dashboard and open the System Information
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
joomla-cms-bot
- | Category | ⇒ | Administration com_admin |
| Status | New | ⇒ | Pending |
in your php.ini file add the following line and restart apache
@brianteeman Which line?
oops - updated the instructions
| Labels |
Added:
PR-4.3-dev
|
||
I have tested this item
```
Warning: Undefined variable $disabled in C:\www\joomla43\administrator\components\com_admin\src\Model\SysinfoModel.php on line 341
Deprecated: explode(): Passing null to parameter #2 ($string) of type string is deprecated in C:\www\joomla43\administrator\components\com_admin\src\Model\SysinfoModel.php on line 341
Line 341 should be
return !\in_array('phpinfo', explode(',', $disabledFunctions));
<hr /><sub>This comment was created with the <a href="https://github.com/joomla/jissues">J!Tracker Application</a> at <a href="https://issues.joomla.org/tracker/joomla-cms/40130">issues.joomla.org/tracker/joomla-cms/40130</a>.</sub>
I have tested this item
Tested successfully in Joomla 4.3.0-beta5-dev of 18 March,
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40130.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40130.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40130.
| Labels |
Added:
?
bug
|
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2023-05-04 19:48:22 |
| Closed_By | ⇒ | obuisard |
Thank you Brian @brianteeman for the PR!
thx
@brianteeman Which line?