[#40127] - [5.0] Migrating from Joomla\CMS\Filesystem\Path to Joomla\Filesystem\Path
- Fixed in Code Base
- 3 Jul 2023
- Medium
- Build: 4.4-dev
- # 40127
- Diff
- Hackwar:4.4-filesystem-path
User tests: Successful: Unsuccessful:
Summary of Changes
In the process of deprecating the CMS Filesystem package (see #40111), this PR changes all usages of Joomla\CMS\Filesystem\Path to Joomla\Filesystem\Path. These 2 classes are almost completely identical, except for one case: Path::clean() in the CMS class uses UnexpectedValueException when the input is not a string, while the Filesystem Path class uses InvalidArgumentException. All other cases where an exception is thrown, the exception in the framework class inherits from the generic Exception which we use in the CMS class. So this is 100% compatible.
While this PR migrates away from the CMS class, #40104 removes most of the old code.
Testing Instructions
Codereview
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
joomla-cms-bot
- | Category | ⇒ | Administration com_admin com_categories com_config com_content com_contenthistory com_fields com_installer com_languages com_menus com_modules com_plugins com_templates com_users |
| Status | New | ⇒ | Pending |
| Labels |
Added:
PR-4.4-dev
|
||
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2023-04-18 12:06:44 |
| Closed_By | ⇒ | Hackwar | |
| Labels |
Added:
bug
|
||
| Status | Closed | ⇒ | New |
| Closed_Date | 2023-04-18 12:06:44 | ⇒ | |
| Closed_By | Hackwar | ⇒ |
| Status | New | ⇒ | Pending |
| Title |
|
||||||
| Labels |
Added:
PR-5.0-dev
Removed: PR-4.4-dev |
||
can you resolve the conflict please, then I can merge this
done
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2023-07-03 11:06:39 |
| Closed_By | ⇒ | HLeithner |
I did a full review on all usages and it looks ok, thanks
I reviewed some of the files and only functions are used which are basically the same like
clean,isOwnerorsetPermissions.