? bug PR-4.3-dev Pending

User tests: Successful: Unsuccessful:

avatar janschoenherr
janschoenherr
15 Mar 2023

If $parts is null this will throw an exception in PHP 8+, a warning in PHP 7.

count(): Argument #1 ($value) must be of type Countable|array, null given

This can happen if the context is e.g. the default context text from the Joomla\CMS\HTML\Helpers\Content::prepare() function.

Pull Request for Issue #40121.

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar joomla-cms-bot joomla-cms-bot - change - 15 Mar 2023
Category Front End Plugins
avatar janschoenherr janschoenherr - open - 15 Mar 2023
avatar janschoenherr janschoenherr - change - 15 Mar 2023
Status New Pending
avatar janschoenherr janschoenherr - change - 15 Mar 2023
Labels Added: ?
avatar joomdonation joomdonation - test_item - 16 Mar 2023 - Tested successfully
avatar joomdonation
joomdonation - comment - 16 Mar 2023

I have tested this item successfully on 85341dd


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40122.

avatar viocassel viocassel - test_item - 17 Mar 2023 - Tested successfully
avatar viocassel
viocassel - comment - 17 Mar 2023

I have tested this item successfully on 85341dd


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40122.

avatar alikon alikon - change - 17 Mar 2023
Status Pending Ready to Commit
avatar alikon
alikon - comment - 17 Mar 2023

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40122.

avatar HLeithner
HLeithner - comment - 2 May 2023

This pull request has been automatically rebased to 4.3-dev.

avatar obuisard
obuisard - comment - 6 May 2023

Hello @janschoenherr, can you check the conflict? Thank you!

avatar joomla-cms-bot joomla-cms-bot - change - 8 May 2023
Category Front End Plugins SQL Administration com_admin Postgresql com_banners com_cache com_categories com_contact com_content com_finder JavaScript com_media NPM Change
avatar janschoenherr janschoenherr - change - 8 May 2023
Labels Added: ? bug
avatar janschoenherr janschoenherr - change - 8 May 2023
Labels Added: NPM Resource Changed PR-4.3-dev
avatar joomla-cms-bot joomla-cms-bot - change - 8 May 2023
Category SQL Administration com_admin Postgresql com_banners com_cache com_categories com_contact com_content com_finder JavaScript com_media NPM Change Front End Plugins
avatar janschoenherr janschoenherr - change - 8 May 2023
Labels Removed: NPM Resource Changed
avatar janschoenherr
janschoenherr - comment - 8 May 2023

Conflicts are resolved. Thanks.

avatar laoneo laoneo - close - 8 May 2023
avatar laoneo laoneo - merge - 8 May 2023
avatar laoneo laoneo - change - 8 May 2023
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2023-05-08 14:13:46
Closed_By laoneo
Labels Removed: ?
avatar laoneo
laoneo - comment - 8 May 2023

Thanks!

Add a Comment

Login with GitHub to post a comment