Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#40117] - [5.1] Revert 40037 and clean up code further

Feature Conflicting Files Maintainers Checked PR-5.0-dev PR-5.1-dev Pending

User tests: Successful: Unsuccessful:

avatar joomdonation
joomdonation
14 Mar 2023

Pull Request for Issue # .

Summary of Changes

This PR reverts #40037 because some maintainers are not happy with set static property of the class base on parameters from constructor. I also make further clean up to the code to optimize performance a bit :

  • Only load plugin language when it is needed (so in the frontend, even someone logged in with special access level or higher, plugin language file won't be loaded)
  • Early returns.

Testing Instructions

  • Use Joomla 4.3 nightly build or any Joomla 4.3-dev installation has guided tours installed
  • Update your site to the update package generated by this PR
  • Try to run a tour, make sure it is still working OK

Actual result BEFORE applying this Pull Request

Works

Expected result AFTER applying this Pull Request

Works with better code and a minor performance improvement for frontend.

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar joomla-cms-bot joomla-cms-bot - change - 14 Mar 2023
Category ⇒ SQL Administration com_admin Postgresql Installation Front End Plugins
avatar joomdonation joomdonation - open - 14 Mar 2023
avatar joomdonation joomdonation - change - 14 Mar 2023
Status New ⇒ Pending
avatar joomdonation joomdonation - change - 15 Mar 2023
Labels Added: PR-4.3-dev
avatar joomdonation joomdonation - change - 15 Mar 2023
The description was changed
avatar joomdonation joomdonation - edited - 15 Mar 2023
avatar joomla-cms-bot joomla-cms-bot - change - 16 Mar 2023
Category SQL Administration com_admin Postgresql Installation Front End Plugins ⇒ Front End Plugins
avatar joomdonation joomdonation - change - 16 Mar 2023
The description was changed
avatar joomdonation joomdonation - edited - 16 Mar 2023
avatar joomdonation
joomdonation - comment - 16 Mar 2023

OK. So I reverted the part which change access level of the plugin to special. It could be done in a separate PR if needed.

avatar Quy
Quy - comment - 31 Mar 2023

Please fix conflict.

avatar obuisard obuisard - change - 28 Jul 2023
Title
…
[4.3] Revert 40037 and clean up code further
[5.0] Revert 40037 and clean up code further
avatar obuisard obuisard - edited - 28 Jul 2023
avatar obuisard
obuisard - comment - 8 Sep 2023

Tuan @joomdonation, do you mind taking a look at the conflicts? I don't want to mess up what you intended to clean up. Thank you, I appreciate it.

avatar HLeithner HLeithner - change - 5 Oct 2023
Title
…
[5.0] Revert 40037 and clean up code further
[5.1] Revert 40037 and clean up code further
avatar HLeithner HLeithner - edited - 5 Oct 2023
avatar joomdonation joomdonation - change - 4 Mar 2024
Status Pending ⇒ Closed
Closed_Date 0000-00-00 00:00:00 ⇒ 2024-03-04 13:07:41
Closed_By ⇒ joomdonation
Labels Added: Feature Conflicting Files Maintainers Checked PR-5.0-dev PR-5.1-dev
Removed: PR-4.3-dev
avatar joomdonation joomdonation - close - 4 Mar 2024

Add a Comment

Login with GitHub to post a comment