? No Code Attached Yet ?
avatar ChristineWk
ChristineWk
14 Mar 2023

A wish/suggestion was expressed in the Joomla.de forum:

Expected result

Between "Delete file" and "Close file" a major visual difference would be an advantage.
Or: A different symbol should be used for close or delete.

Actual result

screen shot 2023-03-14 at 11 00 36

System information (as much as possible)

Joomla 4.2.8 / Joomla 4.2.9-dev

Additional comments

But shouldn't ay11 also be taken into account? (not sure about that)
Maybe someone has an idea about this?

avatar ChristineWk ChristineWk - open - 14 Mar 2023
avatar ChristineWk ChristineWk - change - 14 Mar 2023
Labels Removed: ?
avatar joomla-cms-bot joomla-cms-bot - change - 14 Mar 2023
Labels Added: No Code Attached Yet
avatar joomla-cms-bot joomla-cms-bot - labeled - 14 Mar 2023
avatar brianteeman
brianteeman - comment - 14 Mar 2023

Pretty sure this has come up before.
It is a very valid issue but unfortunately it has wider implications than just in this view.

It is obvious here because we have both buttons at the same time which I don't believe happens elsewhere. So whatever change is made (I would suggest the delete icon is the one that is changed) it needs to be checked against all other occurences

avatar HLeithner
HLeithner - comment - 14 Mar 2023

You may suggest an alternative from https://fontawesome.com/search?q=delete&o=r&m=free at the same time you may replace the floppy symbol with a more state of the are icon. maybe something for @joomla/joomla-experience-team-jxt too

avatar chmst
chmst - comment - 14 Mar 2023

#33515 similar, but it is not the same.

avatar chmst chmst - change - 14 Mar 2023
Labels Added: ?
avatar chmst chmst - labeled - 14 Mar 2023
avatar Fedik
Fedik - comment - 14 Mar 2023

In theory changing this

ToolbarHelper::modal('deleteModal', 'icon-times', 'COM_TEMPLATES_BUTTON_DELETE_FILE', 'btn-danger');

to icon-trash should improve the thing. And will not affect other views.

avatar brianteeman
brianteeman - comment - 14 Mar 2023

#33515 similar, but it is not the same.

ah that was the one I was thinking of

avatar ChristineWk ChristineWk - change - 14 Mar 2023
Title
[4.4] or [5.0]
[4.4] or [5.0] Between "Delete file" and "Close file" a major visual difference would be an advantage
avatar ChristineWk ChristineWk - edited - 14 Mar 2023
avatar brianteeman
brianteeman - comment - 14 Mar 2023

Whatever icon is used it should be used consistently so it is not just here that it should be changed but also in other places such as
image

avatar richard67
richard67 - comment - 14 Mar 2023

In theory changing this

ToolbarHelper::modal('deleteModal', 'icon-times', 'COM_TEMPLATES_BUTTON_DELETE_FILE', 'btn-danger');

to icon-trash should improve the thing. And will not affect other views.

We should not use the trash icon when something is really deleted and not trashed only since a trash icon would make a user think they can find the item somewhere in a trash can after that.

avatar Fedik
Fedik - comment - 14 Mar 2023

In this case I think it will be fine, it will be a "red trash" insteaf of "grey trash" :)
image
Pretty distinguishing to me.
Was just an idea, anyway.

avatar coolcat-creations
coolcat-creations - comment - 15 Mar 2023

"Empty Trash" is anyway a wrong lable for what the button does. Because it does not empty the trash, it only permanently deletes the selected files.
That's why I would also change the text labels.

For Delete File -> Delete Permanently
For Empty Trash -> Delete Permanently
For putting something into the trash -> Move to trash

Suggested Icons
Delete Permanently: Fire or Broom or Attention Symbol with Exclamation Mark or Trashcan with an x
Move to trash: Trashcan, Trashcan with an arrow

avatar Fedik
Fedik - comment - 15 Mar 2023

Other idea is to leave "Delete" as it is, but change "Close file" icon to something else, maybe that is more "easy"

avatar Hackwar Hackwar - change - 16 Mar 2023
Labels Added: ?
avatar Hackwar Hackwar - labeled - 16 Mar 2023
avatar chmst chmst - close - 22 Mar 2023
avatar chmst
chmst - comment - 22 Mar 2023

Thank you @drmenzelit. Please test #40167

avatar chmst chmst - change - 22 Mar 2023
Status New Closed
Closed_Date 0000-00-00 00:00:00 2023-03-22 09:19:50
Closed_By chmst

Add a Comment

Login with GitHub to post a comment