[#40104] - [5.0] Extending Joomla\CMS\Filesystem\Path from Joomla\Filesystem\Path
- Pending
- Medium
- Build: 5.0-dev
- # 40104
- Diff
- Hackwar:5.0-filesystem-path
User tests: Successful: Unsuccessful:
Summary of Changes
This PR extends the CMS Path class from the framework Filesystem Path class. This removes all duplicate code from the CMS class, using the framework methods where possible. This means that now this class throws exceptions.
I've changed this a bit agressively, no remaining method stubs with deprecation notices, but I hope that this is still okay.
This PR would be the extension to #40127
Testing Instructions
Codereview
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
joomla-cms-bot
- | Category | ⇒ | Libraries |
| Status | New | ⇒ | Pending |
| Labels |
Added:
PR-5.0-dev
|
||
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2023-04-18 12:06:44 |
| Closed_By | ⇒ | Hackwar | |
| Labels |
Added:
?
b/c break
|
||
| Status | Closed | ⇒ | New |
| Closed_Date | 2023-04-18 12:06:44 | ⇒ | |
| Closed_By | Hackwar | ⇒ |
| Status | New | ⇒ | Pending |
I would like to move this class to the combat plugin (same for the other deprecated classes) instead of a silent change
Since this is hard to test because it would effect multiple parts of the CMS I merge this into beta1 to get better real world feedback
I checked this again after #40111 was merged. #40127 migrates all calls to this class in the core to the framework class. This PR correctly extends the CMS class from the framework class, hopefully raising awareness to migrate existing code over to the framework class.