[#40099] - [5.0] Extending Joomla\CMS\Filesystem\Stream from Joomla\Filesystem\Stream
- Closed
- 25 Feb 2024
- Medium
- Build: 5.0-dev
- # 40099
- Diff
- Hackwar:5.0-filesystem-stream
- Pending continuous-integration/drone/pr Build is pending Details
User tests: Successful: 0 Unsuccessful: 0
Summary of Changes
This PR extends the CMS Stream classes from the framework Filesystem Stream class. This removes all duplicate code from the CMS class, using the framework methods where possible. This means that now this class throws exceptions.
I've changed this a bit agressively, no remaining method stubs with deprecation notices, but I hope that this is still okay.
Testing Instructions
Codereview
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
joomla-cms-bot
- | Category | ⇒ | Libraries |
| Status | New | ⇒ | Pending |
| Labels |
Added:
PR-5.0-dev
|
||
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2023-04-18 12:06:43 |
| Closed_By | ⇒ | Hackwar | |
| Labels |
Added:
?
b/c break
|
||
| Status | Closed | ⇒ | New |
| Closed_Date | 2023-04-18 12:06:43 | ⇒ | |
| Closed_By | Hackwar | ⇒ |
| Status | New | ⇒ | Pending |
| Labels |
Added:
Feature
Removed: ? |
||
This pull request has been automatically rebased to 5.1-dev.
I doubt this will ever be merged, so I'm closing this.
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2024-02-25 09:14:23 |
| Closed_By | ⇒ | Hackwar |
I reviewed the code again and found a b/c break in the upload method, which I fixed. This is ready to be reviewed again.