[#40094] - [5.0] Extending Joomla\CMS\Filesystem\Folder from Joomla\Filesystem\Folder
- Closed
- 25 Feb 2024
- Medium
- Build: 5.0-dev
- # 40094
- Diff
- Hackwar:5.0-filesystem-folder
User tests: Successful: Unsuccessful:
Summary of Changes
This PR extends the CMS Folder class from the framework Filesystem Folder class. This removes all duplicate code from the CMS class, using the framework methods where possible. This means that now this class throws exceptions and that all FTP remnants are removed.
Looking at the remaining code, we should consider moving some of this into the framework as well.
I've changed this a bit agressively, no remaining method stubs with deprecation notices, no hints at the removed FTP code, but I hope that this is still okay.
Testing Instructions
Everything should work like before... I think this should rather be done by codereview.
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
joomla-cms-bot
- | Category | ⇒ | Libraries |
| Status | New | ⇒ | Pending |
| Labels |
Added:
PR-5.0-dev
|
||
btw. I think documentation is needed for such a change.
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2023-04-18 12:06:42 |
| Closed_By | ⇒ | Hackwar | |
| Labels |
Added:
?
b/c break
|
||
| Status | Closed | ⇒ | New |
| Closed_Date | 2023-04-18 12:06:42 | ⇒ | |
| Closed_By | Hackwar | ⇒ |
| Status | New | ⇒ | Pending |
| Labels |
Added:
Feature
Removed: ? |
||
This pull request has been automatically rebased to 5.1-dev.
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2024-02-25 09:14:50 |
| Closed_By | ⇒ | Hackwar | |
| Labels |
Added:
PR-5.1-dev
|
||
I doubt this will ever be merged, so I'm closing this.
That would be a hard b/c break, we have to move all calls in the CMS to the framework or convert exceptions to errors in this class as long as this class exists.
can't except this for 5.0