? bug PR-4.3-dev ? Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
12 Mar 2023

Summary of Changes

Removes the automatic sorting on the All Tours display.

The problem with the sort is that it is based on the component value eg [com_contact] and not a language value. This results in an ordering that makes no sense in any languatge and also ignores any ordering that is set in the actual component

Testing Instructions

apply pr

Actual result BEFORE applying this Pull Request

image

Expected result AFTER applying this Pull Request

image

You can then if you want to change the ordering of the tours and it will be reflected in the module

image

image

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar joomla-cms-bot joomla-cms-bot - change - 12 Mar 2023
Category Modules Administration
avatar brianteeman brianteeman - open - 12 Mar 2023
avatar brianteeman brianteeman - change - 12 Mar 2023
Status New Pending
avatar richard67 richard67 - change - 12 Mar 2023
Labels Added: PR-4.3-dev
avatar Quy Quy - test_item - 12 Mar 2023 - Tested successfully
avatar Quy
Quy - comment - 12 Mar 2023

I have tested this item successfully on 6086456


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40087.

avatar viocassel viocassel - test_item - 20 Mar 2023 - Tested successfully
avatar viocassel
viocassel - comment - 20 Mar 2023

I have tested this item successfully on 6086456


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40087.

avatar alikon alikon - change - 20 Mar 2023
Status Pending Ready to Commit
avatar alikon
alikon - comment - 20 Mar 2023

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40087.

avatar formfranska formfranska - test_item - 23 Apr 2023 - Tested successfully
avatar formfranska
formfranska - comment - 23 Apr 2023

I have tested this item successfully on 6086456

I have tested this sucessfully.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40087.

avatar obuisard obuisard - change - 4 May 2023
Labels Added: ? bug ?
avatar obuisard obuisard - close - 4 May 2023
avatar obuisard obuisard - merge - 4 May 2023
avatar obuisard obuisard - change - 4 May 2023
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2023-05-04 17:34:43
Closed_By obuisard
avatar obuisard
obuisard - comment - 4 May 2023

Thank you Brian @brianteeman

avatar brianteeman
brianteeman - comment - 4 May 2023

thx

Add a Comment

Login with GitHub to post a comment