PR-5.0-dev Pending

User tests: Successful: Unsuccessful:

avatar richard67
richard67
11 Mar 2023

Pull Request for Issue # .

Summary of Changes

This pull request (PR) updates the lists of deleted files and folders and renamed files in script.php for Joomla 5 and removes the 4.x update SQL scripts.

Both is made under the assumption that updating to Joomla 5 will only be supported from the latest 4.4 release, like it is for updating to Joomla 4 from the latest 3.10 release.

In detail following changes are made:

  • Clear the lists of deleted files and folders and renamed files in script.php by old entries for updating from 3 to 4.
  • Add deleted files and folders from #38406 .
  • Add deleted file from #38405 .
  • Add deleted files and folders from #39134 .
  • Add deleted files and folders and renamed files from dependency updates.
  • Remove the 4.x update SQL scripts (106 files in total, that's why this PR shows 109 changed files on GitHub) and add them to the deleted files list.
  • Add an initial 5.0.0 update SQL script for each database type deleting the #__utf8_conversion table as suggested here: #38406 (comment) . The table should have been deleted long ago, but to be safe we delete it again, if it still exists.

Testing Instructions

Code review.

Or if you want to make a real test, update the latest 4.4-dev nightly build to the last 5.0-dev nightly build to get the actual result, and update the latest 4.4-dev nightly build to the update package built by Drone for this PR to get the expected result.

Actual result BEFORE applying this Pull Request

  • Deleted files and folders from PRs #38406 , #38405 , #39134 and diverse dependencies are still present after updating from the latest 4.4-dev nightly build.
  • The 4.x update SQL scripts are still present.
  • Files "ED256.php" and "ED512.php" in folder "/libraries/vendor/web-auth/cose-lib/src/Algorithm/Signature/EdDSA" have not been renamed to "Ed256.php" and "Ed512.php"

Expected result AFTER applying this Pull Request

  • Deleted files and folders from PRs #38406 , #38405 , #39134 and diverse dependencies have been deleted after updating from the latest 4.4-dev nightly build.
  • The 4.x update SQL scripts have been deleted.
  • Files "ED256.php" and "ED512.php" in folder "/libraries/vendor/web-auth/cose-lib/src/Algorithm/Signature/EdDSA" have been renamed to "Ed256.php" and "Ed512.php"

Link to documentations

Please select:

  • No documentation changes for docs.joomla.org needed

  • No documentation changes for manual.joomla.org needed

avatar joomla-cms-bot joomla-cms-bot - change - 11 Mar 2023
Category Administration com_admin SQL
avatar richard67 richard67 - open - 11 Mar 2023
avatar richard67 richard67 - change - 11 Mar 2023
Status New Pending
avatar richard67 richard67 - change - 11 Mar 2023
The description was changed
avatar richard67 richard67 - edited - 11 Mar 2023
avatar HLeithner HLeithner - close - 11 Mar 2023
avatar HLeithner HLeithner - merge - 11 Mar 2023
avatar HLeithner HLeithner - change - 11 Mar 2023
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2023-03-11 18:22:21
Closed_By HLeithner
Labels Added: PR-5.0-dev
avatar HLeithner
HLeithner - comment - 11 Mar 2023

thanks

Add a Comment

Login with GitHub to post a comment