Language Change PR-4.4-dev Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
10 Mar 2023

code review

the only thing not changed that should be are some of the dates and codenames in version.php

@laoneo

avatar joomla-cms-bot joomla-cms-bot - change - 10 Mar 2023
Category Repository Administration Language & Strings Installation Libraries
avatar brianteeman brianteeman - open - 10 Mar 2023
avatar brianteeman brianteeman - change - 10 Mar 2023
Status New Pending
avatar HLeithner
HLeithner - comment - 10 Mar 2023

I think the language dates are automatically updated by the bump script.

avatar laoneo
laoneo - comment - 10 Mar 2023

Thanks for the pr. Did you do it through the bump script? Next time the RM's will do it as part of our branch process. The build status in the readme's is also wrong. Can you fix this @brianteeman?

avatar brianteeman
brianteeman - comment - 10 Mar 2023

tbh I forgot about bump. I just followed the last commit from Tobias

avatar brianteeman brianteeman - change - 10 Mar 2023
Labels Added: Language Change PR-4.4-dev
avatar laoneo laoneo - close - 10 Mar 2023
avatar laoneo laoneo - merge - 10 Mar 2023
avatar laoneo laoneo - change - 10 Mar 2023
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2023-03-10 15:13:35
Closed_By laoneo
avatar laoneo
laoneo - comment - 10 Mar 2023

Thanks. Will check with the bump script what is missing

Add a Comment

Login with GitHub to post a comment